From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753067AbcHMBU6 (ORCPT ); Fri, 12 Aug 2016 21:20:58 -0400 Received: from mail-co1nam03on0105.outbound.protection.outlook.com ([104.47.40.105]:63774 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752858AbcHMBU4 (ORCPT ); Fri, 12 Aug 2016 21:20:56 -0400 X-Greylist: delayed 10933 seconds by postgrey-1.27 at vger.kernel.org; Fri, 12 Aug 2016 21:20:56 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=kyle.roeschley@ni.com; Date: Fri, 12 Aug 2016 14:47:29 -0500 From: Kyle Roeschley To: Boris Brezillon CC: , , , , , , , , Subject: Re: [PATCH v6 1/2] mtd: nand_bbt: Move BBT block selection logic out of write_bbt() Message-ID: <20160812194729.GA16998@senary> References: <1471024490-32348-1-git-send-email-kyle.roeschley@ni.com> <20160812211503.484e3553@bbrezillon> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160812211503.484e3553@bbrezillon> User-Agent: Mutt/1.6.0 (2016-04-01) X-Originating-IP: [130.164.62.218] X-ClientProxiedBy: SN2PR80CA024.lamprd80.prod.outlook.com (10.141.39.162) To BN6PR04MB0211.namprd04.prod.outlook.com (10.168.224.20) X-MS-Office365-Filtering-Correlation-Id: 4a572956-75fe-4dae-05c5-08d3c2e95809 X-Microsoft-Exchange-Diagnostics: 1;BN6PR04MB0211;2:hdtBuQOyePkM2zeP+VOzRNSRA2R8Oz7ikIdsnEMejxPyo39kgEZhp52h6dWHE2zuMwmsQEuCGsWZ0ZMsP1bFC4N3Qk1AlFLfT0S41NYhsSuwlRJA7Y2yRDPhPLYQ2jDOC8lMKliP4k+PxmcbaWnGXaVLSLVtZ6OqA1k1t94Rp3/pBf99GRElaPrE4ae2zo5v;3:u4GFko9irUwyNndnSy553/+b/QIzSKUJCqxDFJmhB2vaaseDddjgt0wrtMDpAMiJE8hk7oFdOoKo3HACDNuxwNZDV/v9fJ9wJtn2RgujZ1qNHI3b0XmuCXBOyE1IugTQ;25:sR8EiXghl21Zz5Y4xUph4Sblu2BrbVnHQC0Hb2ml1ku0rNHpk/eTUo9Z+P4lC1teky87UFS7O5qgZqlmvC6HRJ3F486xVMxjOO7V0/NM/716Cwx9R6lXwQ9i8f2hA/jFdcxkCmpowIOd197GbL+fce0nV+TlFGYbhoaFiDMwfv6lKFdcpByDzgJzzwdWcByIDNDzN1L347gcPmtjSuodv4i9DAJWa7vYkfn6Bpk8qEkOvnlv4wAnFLRUizRnSK3xXsGpmR07NcyOTIoVAf0SUCEriZgiMZ5+uhrSyFlPr3QmdrcBgWBdJe+/YmtCm9J76vgNQNe4jxHxEE5cPSXDpglKFHJxMqB8/rBOA2s1UbGZjpA/91G6sOqnCgsi2njhP+BhHxDGbhhKCrjH5X4WywwB2cESMlhFGzrqU6XuPxo= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN6PR04MB0211; X-Microsoft-Exchange-Diagnostics: 1;BN6PR04MB0211;31:fNwH1BNQ+JMTfvBk670jmI2KC0jwTvoUKWjyy44g20ES6vlzJbcfhyP9d3Xb0JNnmL0gYIHbl+fOirjCckcqtAjiVAUBzn9YnF/aTdwNyp6SCWQX/zPmY3yq1jvN++kzic5/jObSvsm4StcVlurJ4mg3okASps/csFXqsinnpHZqbe4kmMw0XJy5aCZQnpL1L8aiqudGf39bJaGrMhBYcv23IzNPH1wer39i/JHQpm4=;20:m4MciPGFWRxKC3uzf2nYA+QGkXxvSn4dMYZMaEG2CPrKUZb/J5fAso4h7HbAS+hOGHi1RzDJmN1z/10tnD1hrwVfGuPDYSqBuzM8QYx4K926zOtkk/w4DpMAnq9ugEXH+F1WBiLm4MAiNWYDhB2Z54UDg2qWeqsdJa1Tu/E+tiGMJoe4brz7VorNfAdyL98JMtLC4mRwuLOzozEnkKBFGdQTI9iEQppGCxeHFPkPAbXO62thyNqqpODFvwIrLVNcOUTf7ZTblJnS8jRarrUxGJQr+BXaKfUmK1XvxX5X0wmOv2Nfl6RRK3ffxe2HTG5TG6d00ID9h31U3LZxQsP5Xaewx05uJNjsT+dWsiVJNMXtzIr41LUE2HKOj6a42Yz0dm5dYGB1eabfLYmzXVQBMzOwgbwoqciv5uvAKO4LZTULuOqDOxeiY4kWzG7f5LJ6qBAG8KgOR3TaY/PV+7fNqB+4sdu1MlB6K5y+MIWAmYg9MnzEaeohG07z+4dJ0o85iQl8x2wAgFv9B67aWSVAnHWB3kU1jF3kXU9FohTDF7z02KDVYZ/wHrs2XH6LjxhRSvEzbHUxPqNVvgB0jjkFU7CAtrY5723w2UZhh0Ihq5Y= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(58145275503218)(145744241990776); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:BN6PR04MB0211;BCL:0;PCL:0;RULEID:;SRVR:BN6PR04MB0211; X-Microsoft-Exchange-Diagnostics: 1;BN6PR04MB0211;4:pH2YHnnJTShfvpXzihKhcQmsOd/NjdnEDG1jM5FLxf5lswFJB7ShMh4srEvRQAw7FogXK605SBpQIbCaZJlsk6rUUq/7RoAz818X0mdiFOn1K3fu1+qq/Cxf1sIagLAsp3x3SPgwxUNQ7sLT7PTPUGuIS6mYJJjlnKET0AF9O/mqVc8CxM+qjc2B4zFg5rAULMc+9dnBgCfms5i53jJoqayez0zVkXJwtOaUzAW0zzhJEu900yEtvGkNFRPcvV5sMC0l5mbKIliX+FW6wahYGSKqLWrUbnioN6cU7WD3o/DpRyplcqwYfuiPsKi5lPlFHxZBZbILTsMeE0v07iTzrLnnVl9jJZEHzBb4UJw8q079k8YMm7xCy4hFUfq471dVvKhhAh+4bqwWgsQj++Tsyq29NJuFc11Y6jK0ef5mHKZS5//4qJIshRtOGYUUq9IzzknF8l7uwsgFFT52Vv0DmA== X-Forefront-PRVS: 003245E729 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(189002)(51914003)(199003)(24454002)(97756001)(50466002)(2906002)(105586002)(97736004)(9686002)(4001350100001)(4326007)(46406003)(586003)(189998001)(3846002)(106356001)(1076002)(23726003)(68736007)(33716001)(50986999)(54356999)(101416001)(6116002)(76176999)(110136002)(83506001)(92566002)(77096005)(19580395003)(19580405001)(2950100001)(86362001)(33656002)(7846002)(7736002)(42186005)(81166006)(66066001)(81156014)(8676002)(47776003)(305945005)(18370500001);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR04MB0211;H:senary;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN6PR04MB0211;23:WHsPmxqJdrJITRvvSMXCY9dbKxaef1htBq75xX+0L?= =?us-ascii?Q?BULcvqU0QQaxAHTbpf/YFSxsLAIH2/P30DlqnCLTUyJIiPbwc0lZTyLXEKMb?= =?us-ascii?Q?O5kWwgCrbaSYQYONHBxOnoYfWruQLpXXDWJZhh0KHd4tpYejwsaxOhVtK44a?= =?us-ascii?Q?LPXpSDmNBXfiaqawKVROtzELubz/UG31CF0O0BEu2XoSUrODn907B8i+fDpJ?= =?us-ascii?Q?/qy04DR//q2MUJa2sOjyrTUT6wHMr9Gfl5ASPZuFaIQWpoDeoUtfZ1sPxNDU?= =?us-ascii?Q?Vojn6jfqELCxv58kNvDsgR72ml84jMtPfVz9Rol3+HCu7mktuuJb5EZSAZy7?= =?us-ascii?Q?2l20SAk2q1qQb2isnneimWvyVPEa1PFnNZx2FCglcGWhtAHIVUE0dDwMrWY3?= =?us-ascii?Q?eURnD2f4Xo81QPgspfDPyl6kQzXOyMVi8cUvjCHmmaAPW9yEuO7rskJPCHg1?= =?us-ascii?Q?sq7CILzGdtPGxvlBT7wye7/ktDN4DEJ/rXIfS3Gif1h4pUgJoKL2sFTG1/Mw?= =?us-ascii?Q?JHC4Zue66+nhbihiK9Y7x0vttmCyvI6i+oLWEoNbfxSR2Oan9pcWcyDsrBKB?= =?us-ascii?Q?YYhLdP7Xo933pbCFtbp/NECK8wWLXrxiRQfD5h6SRCxcy2M8f0XxvOfVwGai?= =?us-ascii?Q?PqqYz6b08Pmx6Yjekwp26bQitZiQ+lpr2RXjCNwbUh1xK0RopzBYxFY8kvtP?= =?us-ascii?Q?fw9tF/X5IDeL1c0kNyHfVx502+facJ6Zzc9aSAPZxTU0cbxCrP1YoRzGM2Pz?= =?us-ascii?Q?udy3wXuBd55qcV/lOEAij446B0FFjt3O/L/Bwqio8nSCpzNaJ8BY3IB2ntIi?= =?us-ascii?Q?p9PqLuxXtapKpdKgqd0UpeVJoTj3nh2Cq/i2+Q/lhe2hEzXHnyi+TIs+Hdfr?= =?us-ascii?Q?xJhXu9rZ+H7wL1/wS+odLGDA/0zg2wuZD47lle05MVlmFfm/xcegKJAys8tJ?= =?us-ascii?Q?Y9dYzTpoEYR5neJzSKbDq3MuWDXrHNXPzldi+hM5XkCPCeTyY7ekgb/wj1Xp?= =?us-ascii?Q?Fe0W1xWeeLIDDfuMn3bbfpHaTDPWkKbjocypcwp0kmi8WJgtCayY841BvzD0?= =?us-ascii?Q?Anl1cuNRGkyyBSOOXoNShLcEXYSvwiZ+mGOSQgvdNbIeWHMaffllNEHrezCo?= =?us-ascii?Q?i2mgOb5APNwkg4efGD4jy1bLkMSeM45mju7MvVmB5jlbNV/BMGATg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR04MB0211;6:EqW99KEr9vQz7AaNRs28QkIginl25TsM3r+pUjEWGTOSuS7/ev7vMha2lEWQupnc4fjN/Fzk/93KtmY3EMiTVbqyyPxxPK27yCpre0JXwRwo+mO7a6y6o7BiDIDBQjT7lMzJt8dxKdf3dz+GDprZYlfQqAVH6Y7jrJXLwjOxuEbBn5dRpeImVb7gX1Ka1dNUqe60MlbnIrBwkcM9MjFy2Hg599syg4Y0hZMvh6Q8UIeXUoMHoFAuOziOtv4VsQHo9j2b3bo7sx12Ok9wrj3IXD6UrogrXnpcUprMwIeuNa8=;5:JVxPwVQkKIGWeVL3KDJT03lk9hkVEzKMlcThtIOmEgdhoRQAEIcMnTHsf7Co9IGj30auHMPc3v4zS4ArAIez7o2lFNK5creipR018sVXGq0ogAus4yWZPywp/6CHArTPL4FXb1xRx3EqzG8TRxUysA==;24:J60Q0VXcXcTqIfnKJUw7Ook8wkg0byM0fcjoBwpIU87wsC9KmXADwlSKjaTIZwZbVBkEvU0ydZwOBgELpdB663cNxcpj/D7W9ZDLhLnQqO0=;7:ib0ABC53o4kSCQ3KCylOWPvUbfb9mcvG4GxUSvL/7clm6UD87zg0EMQCn07cSH0H06F2VCe1LPJtJWsXEQQjF+XywM9Pvs90WTg+n8eIDk2rua1AaCbQOvZ5GnvI5YWfH/yszJeAMxYFc3jDhx7xU1OMBumE0/unb8rQ3SWph8UNlsHg6R6+W7fj3Hz1Q4z5m5KnWxXS5Hkq20eNNBzfoob/Il125nxiDOmsKzICU3zoOV18G14TpAz/tOvZ2yPw SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: ni.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2016 19:46:24.4102 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR04MB0211 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris, On Fri, Aug 12, 2016 at 09:15:03PM +0200, Boris Brezillon wrote: > Hi Kyle, > > On Fri, 12 Aug 2016 12:54:49 -0500 > Kyle Roeschley wrote: > > > From: Boris Brezillon > > > > This clarifies the write_bbt() by removing the write label and clarifying > > the error/exit path. > > > > Signed-off-by: Boris Brezillon > > Just want to make sure you actually tested those patches, because I > didn't :). > > Can you add your Tested-by on this one and confirm you've tested patch > 2 as well. Whoops, I goofed and only tested with both patches applied. Thanks for the catch. I'll go ahead and test the first alone and submit a v7. Regards, -- Kyle Roeschley Software Engineer National Instruments