* [PATCH] video: fbdev: mb862xx: mb862xx-i2c: delete now unused "int ret" variable
@ 2016-08-13 18:39 Paul Gortmaker
2016-08-13 18:45 ` Wolfram Sang
0 siblings, 1 reply; 2+ messages in thread
From: Paul Gortmaker @ 2016-08-13 18:39 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-fbdev, Paul Gortmaker, Wolfram Sang, Tomi Valkeinen
In commit 6b610e004baf ("video: fbdev: mb862xx: mb862xx-i2c: don't
print error when adding adapter fails") the users of the variable
were removed, resulting in:
drivers/video/fbdev/mb862xx/mb862xx-i2c.c: In function ‘mb862xx_i2c_init’:
drivers/video/fbdev/mb862xx/mb862xx-i2c.c:160:6: warning: unused variable ‘ret’ [-Wunused-variable]
int ret;
^
...so here we remove the variable as well.
Fixes: 6b610e004baf ("video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding adapter fails)"
Cc: Wolfram Sang <wsa-dev@sang-engineering.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
[Feel free to squash this into the original if you happen to be rebasing]
drivers/video/fbdev/mb862xx/mb862xx-i2c.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/video/fbdev/mb862xx/mb862xx-i2c.c b/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
index 76d206857e3e..ba96c44f2761 100644
--- a/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
+++ b/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
@@ -157,8 +157,6 @@ static struct i2c_adapter mb862xx_i2c_adapter = {
int mb862xx_i2c_init(struct mb862xxfb_par *par)
{
- int ret;
-
mb862xx_i2c_adapter.algo_data = par;
par->adap = &mb862xx_i2c_adapter;
--
2.8.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video: fbdev: mb862xx: mb862xx-i2c: delete now unused "int ret" variable
2016-08-13 18:39 [PATCH] video: fbdev: mb862xx: mb862xx-i2c: delete now unused "int ret" variable Paul Gortmaker
@ 2016-08-13 18:45 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2016-08-13 18:45 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: linux-kernel, linux-fbdev, Wolfram Sang, Tomi Valkeinen
[-- Attachment #1: Type: text/plain, Size: 935 bytes --]
On Sat, Aug 13, 2016 at 02:39:13PM -0400, Paul Gortmaker wrote:
> In commit 6b610e004baf ("video: fbdev: mb862xx: mb862xx-i2c: don't
> print error when adding adapter fails") the users of the variable
> were removed, resulting in:
>
> drivers/video/fbdev/mb862xx/mb862xx-i2c.c: In function ‘mb862xx_i2c_init’:
> drivers/video/fbdev/mb862xx/mb862xx-i2c.c:160:6: warning: unused variable ‘ret’ [-Wunused-variable]
> int ret;
> ^
>
> ...so here we remove the variable as well.
>
> Fixes: 6b610e004baf ("video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding adapter fails)"
> Cc: Wolfram Sang <wsa-dev@sang-engineering.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
Acked-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Thanks! I wonder how this slipped through my and the buildbot checks.
Will investigate...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-14 12:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-13 18:39 [PATCH] video: fbdev: mb862xx: mb862xx-i2c: delete now unused "int ret" variable Paul Gortmaker
2016-08-13 18:45 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox