From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752817AbcHNPt7 (ORCPT <rfc822;w@1wt.eu>);
	Sun, 14 Aug 2016 11:49:59 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:48720 "EHLO
	out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1752169AbcHNPt5 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 14 Aug 2016 11:49:57 -0400
X-Sasl-enc: elwmYzX/C26GG9b6QBhzHGEULIjDtvvVAWomO5TDFLu2 1471189795
Date: Sun, 14 Aug 2016 18:49:53 +0300
From: Ido Schimmel <idosch@idosch.org>
To: Vincent =?iso-8859-1?Q?Stehl=E9?= <vincent.stehle@laposte.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jiri Pirko <jiri@mellanox.com>
Subject: Re: [PATCH] mlxsw: spectrum_router: Fix use after free
Message-ID: <20160814154953.GA31698@splinter>
References: <1471181909-22187-1-git-send-email-vincent.stehle@laposte.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1471181909-22187-1-git-send-email-vincent.stehle@laposte.net>
User-Agent: Mutt/1.6.2 (2016-07-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Aug 14, 2016 at 03:38:29PM +0200, Vincent Stehlé wrote:
> In mlxsw_sp_router_fib4_add_info_destroy(), the fib_entry pointer is used
> after it has been freed by mlxsw_sp_fib_entry_destroy(). Use a temporary
> variable to fix this.
> 
> Fixes: 61c503f976b5449e ("mlxsw: spectrum_router: Implement fib4 add/del switchdev obj ops")
> Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
> Cc: Jiri Pirko <jiri@mellanox.com>

Acked-by: Ido Schimmel <idosch@mellanox.com>

Thank you.