From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752607AbcHOFKs (ORCPT ); Mon, 15 Aug 2016 01:10:48 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33456 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750995AbcHOFKr (ORCPT ); Mon, 15 Aug 2016 01:10:47 -0400 Date: Mon, 15 Aug 2016 07:10:42 +0200 From: Ingo Molnar To: "Rafael J. Wysocki" Cc: Linux PM list , the arch/x86 maintainers , Linux Kernel Mailing List Subject: Re: [PATCH] x86/power/64: Use __pa() for physical address computation Message-ID: <20160815051042.GC16267@gmail.com> References: <5387760.qC5CG883jv@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5387760.qC5CG883jv@vostro.rjw.lan> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > The value of temp_level4_pgt is the physical address of the > top-level page directory, so use __pa() to compute it. > > Signed-off-by: Rafael J. Wysocki > --- > arch/x86/power/hibernate_64.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-pm/arch/x86/power/hibernate_64.c > =================================================================== > --- linux-pm.orig/arch/x86/power/hibernate_64.c > +++ linux-pm/arch/x86/power/hibernate_64.c > @@ -113,7 +113,7 @@ static int set_up_temporary_mappings(voi > return result; > } > > - temp_level4_pgt = (unsigned long)pgd - __PAGE_OFFSET; > + temp_level4_pgt = __pa(pgd); > return 0; > } Acked-by: Ingo Molnar Thanks, Ingo