public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Matt Fleming <matt@codeblueprint.co.uk>
To: Alex Thorlton <athorlton@sgi.com>
Cc: linux-kernel@vger.kernel.org, Russ Anderson <rja@sgi.com>,
	Dimitri Sivanich <sivanich@sgi.com>, Mike Travis <travis@sgi.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, linux-efi@vger.kernel.org,
	Dave Young <dyoung@redhat.com>, Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH] Map in physical addresses in efi_map_region_fixed
Date: Mon, 15 Aug 2016 13:42:58 +0100	[thread overview]
Message-ID: <20160815124258.GF30909@codeblueprint.co.uk> (raw)
In-Reply-To: <1470441575-96065-1-git-send-email-athorlton@sgi.com>

(Cc'ing Boris and Dave)

On Fri, 05 Aug, at 06:59:35PM, Alex Thorlton wrote:
> This is a simple change to add in the physical mappings as well as the
> virtual mappings in efi_map_region_fixed.  The motivation here is to
> get access to EFI runtime code that is only available via the 1:1
> mappings on a kexec'd kernel.
> 
> The added call is essentially the kexec analog of the first __map_region
> that Boris put in efi_map_region in commit d2f7cbe7b26a ("x86/efi:
> Runtime services virtual mapping").
> 
> Signed-off-by: Alex Thorlton <athorlton@sgi.com>
> Cc: Russ Anderson <rja@sgi.com>
> Cc: Dimitri Sivanich <sivanich@sgi.com>
> Cc: Mike Travis <travis@sgi.com>
> Cc: Matt Fleming <matt@codeblueprint.co.uk>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: x86@kernel.org
> Cc: linux-efi@vger.kernel.org
> ---
>  arch/x86/platform/efi/efi_64.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/platform/efi/efi_64.c b/arch/x86/platform/efi/efi_64.c
> index 459bcbb..b206126 100644
> --- a/arch/x86/platform/efi/efi_64.c
> +++ b/arch/x86/platform/efi/efi_64.c
> @@ -363,6 +363,7 @@ void __init efi_map_region(efi_memory_desc_t *md)
>   */
>  void __init efi_map_region_fixed(efi_memory_desc_t *md)
>  {
> +	__map_region(md, md->phys_addr);
>  	__map_region(md, md->virt_addr);
>  }
>  

This looks fine to me. I'm going to run it through my tests and unless
anyone complains, apply it for v4.9.

  parent reply	other threads:[~2016-08-15 12:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-05 23:59 [PATCH] Map in physical addresses in efi_map_region_fixed Alex Thorlton
2016-08-10 17:19 ` Alex Thorlton
2016-08-15 12:42 ` Matt Fleming [this message]
2016-08-15 15:07   ` Borislav Petkov
2016-08-15 18:47     ` Alex Thorlton
2016-08-15 21:52       ` H. Peter Anvin
2016-08-16  5:38         ` Borislav Petkov
2016-08-16  5:50       ` Borislav Petkov
2016-08-16 15:25         ` Alex Thorlton
2016-08-17  7:01       ` Dave Young
2016-08-17 16:00         ` Alex Thorlton
2016-08-18  6:11           ` Dave Young
2016-08-16 12:30     ` Matt Fleming
2016-08-16 13:29       ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160815124258.GF30909@codeblueprint.co.uk \
    --to=matt@codeblueprint.co.uk \
    --cc=athorlton@sgi.com \
    --cc=bp@alien8.de \
    --cc=dyoung@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rja@sgi.com \
    --cc=sivanich@sgi.com \
    --cc=tglx@linutronix.de \
    --cc=travis@sgi.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox