From: Kyle Roeschley <kyle.roeschley@ni.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: <richard@nod.at>, <dwmw2@infradead.org>,
<computersforpeace@gmail.com>, <beanhuo@micron.com>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<nathan.sullivan@ni.com>, <xander.huff@ni.com>,
<peterpansjtu@gmail.com>
Subject: Re: [PATCH v7 1/2] mtd: nand_bbt: Move BBT block selection logic out of write_bbt()
Date: Mon, 15 Aug 2016 09:47:40 -0500 [thread overview]
Message-ID: <20160815144740.GA7067@senary> (raw)
In-Reply-To: <20160813003703.4e86c042@bbrezillon>
On Sat, Aug 13, 2016 at 12:37:03AM +0200, Boris Brezillon wrote:
> On Fri, 12 Aug 2016 16:58:22 -0500
> Kyle Roeschley <kyle.roeschley@ni.com> wrote:
>
[...]
> > + while (chip < nrchips) {
>
> I'm probably missing something, but why are you turning the for loop
> into a while loop in this patch? The commit message does not mention
> that, and I don't see why you need it before you actually start
> reworking the code to recover from BBT write failures (which is done in
> patch 2).
>
You had changed it in patch 2 (http://code.bulix.org/e16nvo-104988) and I just
shuffled it to the first patch since it seemed to make sense as additional code
cleanup. I'll go ahead and drop it though if you don't want it in.
--
Kyle Roeschley
Software Engineer
National Instruments
next prev parent reply other threads:[~2016-08-15 18:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 21:58 [PATCH v7 1/2] mtd: nand_bbt: Move BBT block selection logic out of write_bbt() Kyle Roeschley
2016-08-12 21:58 ` [PATCH v7 2/2] mtd: nand_bbt: scan for next free bbt block if writing bbt fails Kyle Roeschley
2016-08-12 22:37 ` [PATCH v7 1/2] mtd: nand_bbt: Move BBT block selection logic out of write_bbt() Boris Brezillon
2016-08-15 14:47 ` Kyle Roeschley [this message]
2016-08-15 15:28 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160815144740.GA7067@senary \
--to=kyle.roeschley@ni.com \
--cc=beanhuo@micron.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nathan.sullivan@ni.com \
--cc=peterpansjtu@gmail.com \
--cc=richard@nod.at \
--cc=xander.huff@ni.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox