From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752998AbcHOSTt (ORCPT ); Mon, 15 Aug 2016 14:19:49 -0400 Received: from mail-co1nam03on0130.outbound.protection.outlook.com ([104.47.40.130]:65296 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750842AbcHOSTr (ORCPT ); Mon, 15 Aug 2016 14:19:47 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=kyle.roeschley@ni.com; Date: Mon, 15 Aug 2016 09:47:40 -0500 From: Kyle Roeschley To: Boris Brezillon CC: , , , , , , , , Subject: Re: [PATCH v7 1/2] mtd: nand_bbt: Move BBT block selection logic out of write_bbt() Message-ID: <20160815144740.GA7067@senary> References: <1471039103-6745-1-git-send-email-kyle.roeschley@ni.com> <20160813003703.4e86c042@bbrezillon> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160813003703.4e86c042@bbrezillon> User-Agent: Mutt/1.6.0 (2016-04-01) X-Originating-IP: [130.164.62.218] X-ClientProxiedBy: BLUPR08CA0063.namprd08.prod.outlook.com (10.141.200.43) To MWHPR04MB0222.namprd04.prod.outlook.com (10.169.201.147) X-MS-Office365-Filtering-Correlation-Id: 4c32f8b8-ad83-4803-357b-08d3c51af193 X-Microsoft-Exchange-Diagnostics: 1;MWHPR04MB0222;2:/mVh4WHoT8D6ZZOvSgp1KnZ9zK9KN9dI/EPVFtpyICevBxJwXl4KkTpATm3uCFj5LZZPPpC03ZzHXrnF5TDacp+tMAnCOMZBccL4yMZtNqrq8OEBhWAUbI1hYd6HzCFiuTbT/J+reTWitJ3SZ90K8K3CCeKWX52CAbM8l9jPvBzpwiuUPsVgyQkNozX8FlVO;3:V8dX3JtKxX6cmZpqVlWDe+A3x+TMLmXXmMtS2jFy6qS7GGGv7kHvbmshh5NLoJOw09IRD+cVC9OnHMguA1sLhpUYPJ+T0BQWPD9XtKM1KhK/k4Dh2gEm1gDZnRSTtVjR;25:AujCK7vijG3qJ3tPAxmmBs5FQKwHBZFdKHMJQ4tbbtoGpCF6qFnT9eLGBUsLZyQktSNt6uhJAKJgnxB8og2uQNjsr0Mz1ern+L6zJV4ClTWHGT3flKHWpQIYgC5jfglPfbmPvxP98J2VHithrTU9+1Sr+9yyOD3hVKcz7RHnkaAt4G01xidyznEn5XagYnlIGXEQ98VWEFyVD7M0xLssE151Qv0PaxUk4NKXWFEiwiKenbyjVlm0ib927n3gHLmO+wMjD8xnxCRgdaWij1YL9rTTpi4ORKRA4Jhh164bTGYNLOr+QAzejvzHR0e0Dnajh2npR8Qaj3/U4lVoV9Bc3t6cHX/SZ3RLcz2EjvN1pAVNwNGYa3K4cOyDv1KXIl2PKKUBrRDFcm4QZKcajh/xhBjJurlDEUdY83SnqakvI9Q= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:MWHPR04MB0222; X-Microsoft-Exchange-Diagnostics: 1;MWHPR04MB0222;31:7EXI3radMkrs7lFD0E0g0BBnlzYmPZ4vbsBBfQZtRAAiK6bFph4b4/LX0SGIgrNaOXBIWurtQss/vhFA7KeUhy5ZXvKQpUqtCvhBvNBJshImBrCpk9ie5LO4PjY0Bx/6bkoDXYS4t+C5MbTdSV6HA04HmTM3XFLxhb6s1rTkVSqLp0s5VWpRIBTZkgMcu4rRmLbiOyF17T1eSs+1RZiOFnfIFTz6DbgoT/Qf9V+BCjA=;20:yu+ax0aHPdpHQYd+uKQRN3x1fovXQ8JzhiLYJFlTm7G8bXK4eb2OLKo4WG5XC3IoJE3+ECDrZ6c+JP6gnYILwmMtar8jKPCpuat3pRd0CMGEpx+IsGb3rspYJugoyb0nwKvPHcL6iVD6LwcsdMDjfU8VJF5wzl2pof/uzFvO0YkbxQyv0kTxTWWgEPDO6Oea3+4/i3aeIsl0vOw6E6czvH6QZU3tml9n6/ZbFcdqNTEbCLNH3ceLeYkyfxwcz8aCkXvTiUbAmTAxe927Tc7aJpAgm4AwltPsKTSqJC1wTZ+zFgxip2eVcpKgIJrbAsOrbJ9uuuabshFE76Rxpdch+gTMIwb4zxCvj09vbC73GofS81wwxpdZKAB/R4biWfyPsM+a5gdWcJryimuhRTlfOCONiFUKc3EtLxR2d/cAq2X5f+M3hEMR5mrqgX533kSkJLZqSExLqqUTx0C5cuyW/IxmILPY7x+4K5wVywdprw+FBfb/+/BI3CSIqUHg1NOg58BwHlnvQmsnHMfzELXisNLJC6po+Kyh8vAm5bk5rUUdboqkZmSY0MiTHhAdcsA0s5qefTOt8Yfojh/03gJ9qfCNecruGUjkTjIWyhKqa+g= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(145744241990776); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:MWHPR04MB0222;BCL:0;PCL:0;RULEID:;SRVR:MWHPR04MB0222; X-Microsoft-Exchange-Diagnostics: 1;MWHPR04MB0222;4:dulaJJotL3AFa73etgbjKHJ20M11TxkTxnuSlkMSxs9H6oGsPNa24fSFV/Fx+kVAOyqFNlxvImassgygkmHO7gY+s3+fTRhPL1ohZ/LC+p+eO5wg0h5o8V/SRdc/dTYt5Rf1+RI5TxHSiOO1PwVQlFUW1SAyZEOnzs0qd//bKmg+zyUU3aGnQFH6jAYy0oUMj5JeVy0fD1luk1D9nkpxvLhtN9G9hbaiiQuSkiklzMZej5w8K6u9m/NPkcDSVW7sKilOHbiMkJqNJ72AbJPnLGx0mNu8RIJXSVAZamlzRW7L9KkAPLZgZ5S+SzMNedR8OSEE7vnf7/8Y9ZJxPqmNNRM9UZc9mv120LGOOKewaAAlhsuMcjYtKYTdrjAUTfTx2kc/9OWbC4R8UPsDiwvqE7wpDlvQ0v/vsEVf9hZAW/jP1xelVU+as9/bcFlnzBvN X-Forefront-PRVS: 0035B15214 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(189002)(24454002)(199003)(23726003)(305945005)(33716001)(97736004)(50466002)(33656002)(8676002)(7736002)(189998001)(4326007)(110136002)(46406003)(106356001)(7846002)(2906002)(1076002)(77096005)(50986999)(76176999)(4001350100001)(15975445007)(54356999)(66066001)(83506001)(19580405001)(19580395003)(586003)(47776003)(9686002)(86362001)(68736007)(6116002)(42186005)(3846002)(105586002)(101416001)(2950100001)(81166006)(81156014)(92566002)(97756001)(18370500001);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR04MB0222;H:senary;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;MWHPR04MB0222;23:869n7zkLerN8To+dsrQtKvdivJWUAEIhAE+JkJePV?= =?us-ascii?Q?IAPlbK9iujXA+DViGaU+NrSePPl/lj+HTQXQUrnYHZEgx9aNrWMInGt6IDQK?= =?us-ascii?Q?zhxGppjz1rOMKwkf7nuETdVeZk7VHq4uhV8mTTBMVBH+Mz86pBTBd+t0xYMI?= =?us-ascii?Q?16rvN/9YIzo5XcEc3egGbqqbR4ocTJQsAR4cpEArLlXrGWRBSMAE/LHIZ41o?= =?us-ascii?Q?Lw9Vl9XvJT0pWAmd9rDihc7tngyfBay3MlNH6DjxsVdnOGiDYKowqWERtzS5?= =?us-ascii?Q?va+TB/aZh8meS2AkKn+7z5O9g6OU7DUk+p/SpnPler2OqI7YEEadHAe9pyDj?= =?us-ascii?Q?7dbgwf5eqXDErjBG43P2t2hglE31xE4tJ2QrJ4+ct/cZQj1tTTohDL8DdlUE?= =?us-ascii?Q?jnXBeXcI46OdMbhUYkMC3cbMWnvDAj+/0Trj2a5J4J+mQt8BTbFXUoOIkiIS?= =?us-ascii?Q?Xl2JbMKjVfu3BJTTXCoUFexIFjc6ER0O9TXbTauLDOFzWJ63ZsbLT5An1bxD?= =?us-ascii?Q?t+DnT4+GcrIXTGwaze9eVmDSFG7uQ3a/t0WKWAw3TuRbm48A+HNaN3yEHJcN?= =?us-ascii?Q?nLRN9jER1zePT/lUhVyZX+tNylwvh2AP8DWG2YfSCPtd3ikBMDEikLN+2dqp?= =?us-ascii?Q?czU2tn9tWhQePsRRjlVJeS/3OIkj+w18+ZPux0S+I1/3kMWyOMzXW7aBnPzv?= =?us-ascii?Q?K3d0lEBF1AYQhWmTriQC0oBShNW2x1bR22ptqfo5BJ2JPs4oXnFdlpmA4/X7?= =?us-ascii?Q?1pJKKB9pS078ZNhdi6jCH/w4EG+s+iNZNZ8mBliSPMtzJdqf76N8X3i6RER/?= =?us-ascii?Q?AlIwg4CKMtyxUY4wwGxgpZPCaEqYrrKv0GbKt6e6GeiCQ9QSqyPbHFPx4wU3?= =?us-ascii?Q?GQ2myPAn0P/YEaT6gtp1GjrWmPUSuuhBBmmYHPtizBgqdtqUmiZyeVKMdNnm?= =?us-ascii?Q?DdMBxK75ileJ/DishXkNgcLs03MYW47qq8wmJ+R21mvoWsJmwVh1cxzzDNES?= =?us-ascii?Q?nsV6fAeepQoYKQrACQnWH5tWsS0bkgESAISZNbeau5ktt2KHAwCjS83CsuY4?= =?us-ascii?Q?5QzYD8rx82KwOPk8CovgdbhM3TQsKvqwpeHGpZLmkG7LHjqNM1VcDzwOudRw?= =?us-ascii?Q?nAi1xLRYb6/9kkUviF9ZQKXebqaErINf41WLXM+9sAE2CUGzO/M/g=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR04MB0222;6:5sA2SW72L2XqoRdm5BiyfIAo8sGGyjygeQn+8ddXR/EItCJrohX4thfXW+nG3exNbR4aJgSb+Mt3rjQ27A+t/RzDJb0jnA/litReZgD/v+5395rA0p7YJfqsy81kJD5w5h01+hH/+oaXH7Y9/3TBtNigJEWA/ylSmlEIvGlNMdsLgGUn3+CVVid6zxeXMEvDf/zzDccmdlEBnIoXnuQyVcHrTm1eR7Jyf/2mnwlxZ4NyMVgjYA39DMGeJ9IYFThLbg1pec2hXhHAHwDJEpv2QtTkPypf3WzBVjLrV+ywFOM=;5:yyZaF3yB6IFUOnm21LugOgp2+kU2l2xrPnUTV9D+v/WpRb579JcIFg9EaJax3Q8lcSmkAe3P+s+wmQtummBlAEl+pZ9XE/fKnfCU1gegHwBUCpwPBcYALJpG8GWEngjkmR6dTMX99zDj7OglGu+PKw==;24:zeJIGTyvs1APeoLrt83Lz/mFJ2NQ+w63pKpJA/zsuqfZ57qRbei2HhtLFqklrn20bQvUrDfmgCGIBiZs3opIWInuttThyIxYG4BPmutBTVk=;7:4FGN9FtQ7wvqKqtrAoIkyJyONZZ35s6pWKTthOeuHqh6S2WBxVMDIfMtdNkd+HciaL2ce51FYyxOcoCOFLeZpp922TnmhfzqjrydpCDBgtV+SuQTZNRhx30lmNQ19VtBdgSsvIGI7+ojycIjJx8Zptu+1oZ4aden7iF7ta8BArxzlubfN4FfFi8LCBp/RkFg30PFG8o4KtSk21v0kj6D9BesHHjdT+ROp3uXW3uBONYhi4/egBS1p6q0WfyEkxIQ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: ni.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Aug 2016 14:46:28.9199 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR04MB0222 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 13, 2016 at 12:37:03AM +0200, Boris Brezillon wrote: > On Fri, 12 Aug 2016 16:58:22 -0500 > Kyle Roeschley wrote: > [...] > > + while (chip < nrchips) { > > I'm probably missing something, but why are you turning the for loop > into a while loop in this patch? The commit message does not mention > that, and I don't see why you need it before you actually start > reworking the code to recover from BBT write failures (which is done in > patch 2). > You had changed it in patch 2 (http://code.bulix.org/e16nvo-104988) and I just shuffled it to the first patch since it seemed to make sense as additional code cleanup. I'll go ahead and drop it though if you don't want it in. -- Kyle Roeschley Software Engineer National Instruments