From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753193AbcHOQZV (ORCPT ); Mon, 15 Aug 2016 12:25:21 -0400 Received: from mail.kernel.org ([198.145.29.136]:44326 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752887AbcHOQYp (ORCPT ); Mon, 15 Aug 2016 12:24:45 -0400 Date: Mon, 15 Aug 2016 13:24:39 -0300 From: Arnaldo Carvalho de Melo To: Hekuang Cc: peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, wangnan0@huawei.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] perf script: Don't disable use_callchain if input is pipe Message-ID: <20160815162439.GA20972@kernel.org> References: <1470309943-153909-1-git-send-email-hekuang@huawei.com> <1470309943-153909-2-git-send-email-hekuang@huawei.com> <57B1988B.3020806@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <57B1988B.3020806@huawei.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Aug 15, 2016 at 06:25:15PM +0800, Hekuang escreveu: > ping. Thanks, tested and applied both patches. - Arnaldo > 在 2016/8/4 19:25, He Kuang 写道: > > Because perf data from pipe do not have a header with evsel attr, we > > should not check that and disable symbol_conf.use_callchain. Otherwise, > > perf script won't show callchains even if the data stream contains > > callchain. > > > > Before: > > $ perf record -g -o - uname |perf script > > Linux > > [ perf record: Woken up 1 times to write data ] > > [ perf record: Captured and wrote 0.000 MB - ] > > uname 1828 182630.186578: 250000 cpu-clock: ..b9499 setup_arg_pages > > uname 1828 182630.186850: 250000 cpu-clock: ..83b20 ___might_sleep > > uname 1828 182630.187153: 250000 cpu-clock: ..4b6be file_map_prot_ch > > ... > > > > After: > > $ perf record -g -o - uname |perf script > > Linux > > [ perf record: Woken up 1 times to write data ] > > [ perf record: Captured and wrote 0.000 MB - ] > > uname 1833 182675.927099: 250000 cpu-clock: > > ba5520 _raw_spin_lock+0xfe200040 ([kernel.kallsyms]) > > 389dd4 expand_downwards+0xfe200154 ([kernel.kallsyms]) > > 389f34 expand_stack+0xfe200024 ([kernel.kallsyms]) > > 3b957e setup_arg_pages+0xfe20019e ([kernel.kallsyms]) > > 40c80f load_elf_binary+0xfe20042f ([kernel.kallsyms]) > > ... > > > > Signed-off-by: He Kuang > > --- > > tools/perf/builtin-script.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c > > index d47aef9..ec8df8f 100644 > > --- a/tools/perf/builtin-script.c > > +++ b/tools/perf/builtin-script.c > > @@ -371,14 +371,16 @@ static int perf_session__check_output_opt(struct perf_session *session) > > if (!no_callchain) { > > bool use_callchain = false; > > + bool not_pipe = false; > > evlist__for_each_entry(session->evlist, evsel) { > > + not_pipe = true; > > if (evsel->attr.sample_type & PERF_SAMPLE_CALLCHAIN) { > > use_callchain = true; > > break; > > } > > } > > - if (!use_callchain) > > + if (not_pipe && !use_callchain) > > symbol_conf.use_callchain = false; > > } >