From: Arnd Bergmann <arnd@arndb.de>
To: Fabian Frederick <fabf@skynet.be>
Cc: Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1 linux-next] hwrng: update Freescale i.MX RNGA Random Number Generator
Date: Mon, 15 Aug 2016 17:05:25 +0200 [thread overview]
Message-ID: <201608151705.25484.arnd@arndb.de> (raw)
In-Reply-To: <1471036858-10537-1-git-send-email-fabf@skynet.be>
On Friday 12 August 2016, Fabian Frederick wrote:
> We can directly depend on SOC_IMX31 since
> commit c9ee94965dce
> ("ARM: imx: deconstruct mxc_rnga initialization")
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Did I cause a regression with my patch, without this change? If so, this should be
marked
Cc: stable@vger.kernel.org
Fixes: c9ee94965dce ("ARM: imx: deconstruct mxc_rnga initialization")
and the patch applied ASAP.
> ---
> drivers/char/hw_random/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
> index 56ad5a59..8c0770b 100644
> --- a/drivers/char/hw_random/Kconfig
> +++ b/drivers/char/hw_random/Kconfig
> @@ -244,7 +244,7 @@ config HW_RANDOM_TX4939
>
> config HW_RANDOM_MXC_RNGA
> tristate "Freescale i.MX RNGA Random Number Generator"
> - depends on ARCH_HAS_RNGA
> + depends on SOC_IMX31
> default HW_RANDOM
It would be nice to add "|| COMPILE_TEST here", but that should probably be
a separate patch, as we don't want to backport that or treat it as a bugfix.
Arnd
next prev parent reply other threads:[~2016-08-15 15:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 21:20 [PATCH 1/1 linux-next] hwrng: update Freescale i.MX RNGA Random Number Generator Fabian Frederick
2016-08-15 15:05 ` Arnd Bergmann [this message]
2016-08-15 17:04 ` Fabian Frederick
2016-08-16 9:57 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201608151705.25484.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=fabf@skynet.be \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox