public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>,
	Andreas Dilger <andreas.dilger@intel.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	lustre-devel@lists.lustre.org
Subject: Re: [PATCH 1/2] staging: lustre: Add include path to Makefile
Date: Mon, 15 Aug 2016 23:04:20 +0200	[thread overview]
Message-ID: <20160815210420.GA30864@kroah.com> (raw)
In-Reply-To: <5f9f49c1e0caeb3b9ee0656b6d922dbaf52a15b7.1471289489.git.joe@perches.com>

On Mon, Aug 15, 2016 at 12:33:23PM -0700, Joe Perches wrote:
> Start to rationalize include paths in source code files.
> 
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  drivers/staging/lustre/Makefile | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/staging/lustre/Makefile b/drivers/staging/lustre/Makefile
> index 95ffe33..9d00237 100644
> --- a/drivers/staging/lustre/Makefile
> +++ b/drivers/staging/lustre/Makefile
> @@ -1,2 +1,5 @@
> +subdir-ccflags-y += -I$(srctree)/drivers/staging/lustre/include/
> +subdir-ccflags-y += -I$(srctree)/drivers/staging/lustre/lustre/include/
> +
>  obj-$(CONFIG_LNET)		+= lnet/
>  obj-$(CONFIG_LUSTRE_FS)		+= lustre/

This is good, but does this break the subdir make command:
	make M=drivers/staging/lustre/foo_dir/
?

I remember the last time I tried to clean this up, it took a while...

thanks,

greg k-h

  reply	other threads:[~2016-08-15 21:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-15 19:33 [PATCH 0/2] staging: lustre: #include neatening Joe Perches
2016-08-15 19:33 ` [PATCH 1/2] staging: lustre: Add include path to Makefile Joe Perches
2016-08-15 21:04   ` Greg Kroah-Hartman [this message]
2016-08-15 21:08     ` [lustre-devel] " James Simmons
2016-08-15 21:14     ` Joe Perches
2016-08-15 21:29       ` Building a subdirectory ignores parent subdir-ccflags (was: Re: [PATCH 1/2] staging: lustre: Add include path to Makefile) Joe Perches
2016-08-15 22:07         ` Building a subdirectory ignores parent subdir-ccflags Michal Marek
2016-08-15 22:46           ` Joe Perches
2016-08-16 10:53       ` [PATCH 1/2] staging: lustre: Add include path to Makefile Greg Kroah-Hartman
2016-08-16 11:01         ` Joe Perches
2016-08-15 19:33 ` [PATCH 2/2] staging: lustre: Remove .. paths from '#include "' uses Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160815210420.GA30864@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lustre-devel@lists.lustre.org \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox