From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932402AbcHOWk0 (ORCPT ); Mon, 15 Aug 2016 18:40:26 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:57549 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932332AbcHOWkU (ORCPT ); Mon, 15 Aug 2016 18:40:20 -0400 Date: Mon, 15 Aug 2016 15:40:18 -0700 From: Stephen Boyd To: Laxman Dewangan Cc: mturquette@baylibre.com, robh+dt@kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Javier Martinez Canillas Subject: Re: [PATCH V3 1/4] clk: max77686: Combine Maxim max77686 and max77802 driver Message-ID: <20160815224018.GO361@codeaurora.org> References: <1466160667-28451-1-git-send-email-ldewangan@nvidia.com> <1466160667-28451-2-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466160667-28451-2-git-send-email-ldewangan@nvidia.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/17, Laxman Dewangan wrote: > The clock IP used on the Maxim PMICs max77686 and max77802 are > same. The configuration of clock register is also same except > the number of clocks. > > Part of common code utilisation, there is 3 files for these chips > clock driver, one for common and two files for driver registration. > > Combine both drivers into single file and move common code into > same common file reduces the 2 files and make max77686 and max77802 > clock driver in single fine. This driver does not depends on the > parent driver structure. The regmap handle is acquired through > regmap APIs for the register access. > > This combination of driver helps on adding clock driver for different > Maxim PMICs which has similar clock IP like MAX77620 and MAX20024. > > Signed-off-by: Laxman Dewangan > CC: Krzysztof Kozlowski > CC: Javier Martinez Canillas > Reviewed-by: Javier Martinez Canillas > Tested-by: Javier Martinez Canillas > Reviewed-by: Krzysztof Kozlowski > Tested-by: Krzysztof Kozlowski > > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project