From: Tejun Heo <tj@kernel.org>
To: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Cc: Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/8] Remove deprecated workqueue interface users
Date: Mon, 15 Aug 2016 18:59:48 -0400 [thread overview]
Message-ID: <20160815225948.GG3672@mtj.duckdns.org> (raw)
In-Reply-To: <cover.1471104124.git.bhaktipriya96@gmail.com>
On Sat, Aug 13, 2016 at 09:41:21PM +0530, Bhaktipriya Shridhar wrote:
> This patch set removes the instances of deprecated
> create_singlethread_workqueues in drivers/power by making the appropriate
> conversions.
>
> Bhaktipriya Shridhar (8):
> power: abx500_chargalg: Remove deprecated create_singlethread_workqueue
> power: ab8500_btemp: Remove deprecated create_singlethread_workqueue
> power: pm2301_charger: Remove deprecated create_singlethread_workqueue
> power: intel_mid_battery: Remove deprecated create_singlethread_workqueue
> power: ab8500_charger: Remove deprecated create_singlethread_workqueue
> power: ipaq_micro_battery: Remove deprecated create_singlethread_workqueue
> power: ab8500_fg: Remove deprecated create_singlethread_workqueue
> power: ds2760_battery: Remove deprecated create_singlethread_workqueue
Patches look good to me. I'm a bit curious about WQ_MEM_RECLAIM part
tho. I suppose the reasoning is that as the hardware in question is
involved in battery management which may be time critical,
WQ_MEM_RECLAIM is added to ensure (timely) forward progress under
memory pressure, right? It'd be great if someone who's more familiar
with these hardware can confirm whether this is actually necessary.
Oh, it'd also be nice to put the target subsystem in the subject of
the patchset - e.g. "[PATCH 0/8] power: Remove..."
Thanks.
--
tejun
next prev parent reply other threads:[~2016-08-15 22:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-13 16:11 [PATCH 0/8] Remove deprecated workqueue interface users Bhaktipriya Shridhar
2016-08-13 16:16 ` [PATCH 1/8] power: abx500_chargalg: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar
2016-08-15 22:56 ` [PATCH 0/8] Remove deprecated workqueue interface users Sebastian Reichel
2016-08-15 22:59 ` Tejun Heo [this message]
2016-08-16 0:23 ` Sebastian Reichel
2016-08-16 14:51 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160815225948.GG3672@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=bhaktipriya96@gmail.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox