From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753103AbcHPH5b (ORCPT <rfc822;w@1wt.eu>);
	Tue, 16 Aug 2016 03:57:31 -0400
Received: from mail-wm0-f52.google.com ([74.125.82.52]:35541 "EHLO
	mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750928AbcHPH53 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 16 Aug 2016 03:57:29 -0400
Date: Tue, 16 Aug 2016 09:57:21 +0200
From: Richard Cochran <richardcochran@gmail.com>
To: Rik van Riel <riel@redhat.com>
Cc: Jouni Malinen <jkmalinen@gmail.com>, Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Paul McKenney <paulmck@linux.vnet.ibm.com>,
        Frederic Weisbecker <fweisbec@gmail.com>, Chris Mason <clm@fb.com>,
        Arjan van de Ven <arjan@infradead.org>, rt@linutronix.de,
        George Spelvin <linux@sciencehorizons.net>,
        Len Brown <lenb@kernel.org>, Josh Triplett <josh@joshtriplett.org>,
        Eric Dumazet <edumazet@google.com>
Subject: Re: [patch 4 14/22] timer: Switch to a non cascading wheel
Message-ID: <20160816075721.GA23077@localhost.localdomain>
References: <20160704093956.299369787@linutronix.de>
 <20160704094342.108621834@linutronix.de>
 <CANe27j+-sm3nVZZg0U2LWCduKMVw6WJJwMa6aSaxB5M-d53kPw@mail.gmail.com>
 <1471024216.32433.5.camel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1471024216.32433.5.camel@redhat.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Aug 12, 2016 at 01:50:16PM -0400, Rik van Riel wrote:
> Could that cause the new timer wheel code to skip over
> timer buckets occasionally, or is this hypothesis bunk?

The new wheel is not different from the old one in this respect.  Each
base keeps its own jiffies counter.  When returning from a long sleep,
the base counter can be behind the current jiffies value by more than
one.  In __run_timers() we loop through all the missed jiffies:

	while (time_after_eq(jiffies, base->clk)) {

		levels = collect_expired_timers(base, heads);
		base->clk++;

		while (levels--)
			expire_timers(base, heads + levels);
	}

So the hypothesis is incorrect.

Thanks,
Richard