From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Tal Shorer <tal.shorer@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, balbi@kernel.org
Subject: Re: [PATCH v2 03/10] usb: ulpi: use new api functions if available
Date: Tue, 16 Aug 2016 13:55:17 +0300 [thread overview]
Message-ID: <20160816105517.GC9927@kuha.fi.intel.com> (raw)
In-Reply-To: <1470075358-19792-4-git-send-email-tal.shorer@gmail.com>
Hi,
On Mon, Aug 01, 2016 at 09:15:51PM +0300, Tal Shorer wrote:
> If the registered has the new api callbacks {read|write}_dev, call
> these instead of the deprecated read, write functions. If the
> registered does not support the new callbacks, revert to calling the
> old ones as before.
>
> Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
> ---
> drivers/usb/common/ulpi.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c
> index d1f419c..a877ddb 100644
> --- a/drivers/usb/common/ulpi.c
> +++ b/drivers/usb/common/ulpi.c
> @@ -21,13 +21,17 @@
>
> int ulpi_read(struct ulpi *ulpi, u8 addr)
> {
> - return ulpi->ops->read(ulpi->ops, addr);
> + if (!ulpi->ops->read_dev)
> + return ulpi->ops->read(ulpi->ops, addr);
> + return ulpi->ops->read_dev(ulpi->dev.parent, addr);
> }
> EXPORT_SYMBOL_GPL(ulpi_read);
>
> int ulpi_write(struct ulpi *ulpi, u8 addr, u8 val)
> {
> - return ulpi->ops->write(ulpi->ops, addr, val);
> + if (!ulpi->ops->write_dev)
> + return ulpi->ops->write(ulpi->ops, addr, val);
> + return ulpi->ops->write_dev(ulpi->dev.parent, addr, val);
> }
> EXPORT_SYMBOL_GPL(ulpi_write);
>
> --
> 2.7.4
Squash patches 2-3 into one patch.
Thanks,
--
heikki
next prev parent reply other threads:[~2016-08-16 10:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 18:15 [PATCH v2 00/10] usb: ulpi: remove "dev" field from struct ulpi_ops Tal Shorer
2016-08-01 18:15 ` [PATCH v2 01/10] usb: ulpi: move setting of ulpi->dev parent up in ulpi_register() Tal Shorer
2016-08-01 18:15 ` [PATCH v2 02/10] usb: ulpi: add new api functions, {read|write}_dev() Tal Shorer
2016-08-01 18:15 ` [PATCH v2 03/10] usb: ulpi: use new api functions if available Tal Shorer
2016-08-16 10:55 ` Heikki Krogerus [this message]
2016-08-01 18:15 ` [PATCH v2 04/10] usb: dwc3: ulpi: use new api Tal Shorer
2016-08-01 18:15 ` [PATCH v2 05/10] usb: ulpi: remove calls to old api callbacks Tal Shorer
2016-08-01 18:15 ` [PATCH v2 06/10] usb: ulpi: remove old api callbacks from struct ulpi_ops Tal Shorer
2016-08-16 10:55 ` Heikki Krogerus
2016-08-01 18:15 ` [PATCH v2 07/10] usb: ulpi: rename operations {read|write}_dev to simply {read|write} Tal Shorer
2016-08-01 18:15 ` [PATCH v2 08/10] usb: ulpi: remove "dev" field from struct ulpi_ops Tal Shorer
2016-08-16 10:58 ` Heikki Krogerus
2016-08-01 18:15 ` [PATCH v2 09/10] usb: ulpi: make ops struct constant Tal Shorer
2016-08-01 18:15 ` [PATCH v2 10/10] usb: dwc3: ulpi: make dwc3_ulpi_ops constant Tal Shorer
2016-08-09 14:04 ` [PATCH v2 00/10] usb: ulpi: remove "dev" field from struct ulpi_ops Greg KH
2016-08-09 15:55 ` Tal Shorer
2016-08-09 16:43 ` Greg KH
2016-08-15 12:02 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160816105517.GC9927@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tal.shorer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox