From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753407AbcHPKz3 (ORCPT ); Tue, 16 Aug 2016 06:55:29 -0400 Received: from mga04.intel.com ([192.55.52.120]:50055 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753136AbcHPKz2 (ORCPT ); Tue, 16 Aug 2016 06:55:28 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,529,1464678000"; d="scan'208";a="866206940" Date: Tue, 16 Aug 2016 13:55:17 +0300 From: Heikki Krogerus To: Tal Shorer Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, balbi@kernel.org Subject: Re: [PATCH v2 03/10] usb: ulpi: use new api functions if available Message-ID: <20160816105517.GC9927@kuha.fi.intel.com> References: <1470075358-19792-1-git-send-email-tal.shorer@gmail.com> <1470075358-19792-4-git-send-email-tal.shorer@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1470075358-19792-4-git-send-email-tal.shorer@gmail.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Aug 01, 2016 at 09:15:51PM +0300, Tal Shorer wrote: > If the registered has the new api callbacks {read|write}_dev, call > these instead of the deprecated read, write functions. If the > registered does not support the new callbacks, revert to calling the > old ones as before. > > Signed-off-by: Tal Shorer > --- > drivers/usb/common/ulpi.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c > index d1f419c..a877ddb 100644 > --- a/drivers/usb/common/ulpi.c > +++ b/drivers/usb/common/ulpi.c > @@ -21,13 +21,17 @@ > > int ulpi_read(struct ulpi *ulpi, u8 addr) > { > - return ulpi->ops->read(ulpi->ops, addr); > + if (!ulpi->ops->read_dev) > + return ulpi->ops->read(ulpi->ops, addr); > + return ulpi->ops->read_dev(ulpi->dev.parent, addr); > } > EXPORT_SYMBOL_GPL(ulpi_read); > > int ulpi_write(struct ulpi *ulpi, u8 addr, u8 val) > { > - return ulpi->ops->write(ulpi->ops, addr, val); > + if (!ulpi->ops->write_dev) > + return ulpi->ops->write(ulpi->ops, addr, val); > + return ulpi->ops->write_dev(ulpi->dev.parent, addr, val); > } > EXPORT_SYMBOL_GPL(ulpi_write); > > -- > 2.7.4 Squash patches 2-3 into one patch. Thanks, -- heikki