From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753592AbcHPOhU (ORCPT ); Tue, 16 Aug 2016 10:37:20 -0400 Received: from mail.kernel.org ([198.145.29.136]:43652 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753571AbcHPOge (ORCPT ); Tue, 16 Aug 2016 10:36:34 -0400 Date: Tue, 16 Aug 2016 11:36:28 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Jiri Olsa , Linux Kernel Mailing List Subject: RFC: callchain showing same entry as hist_entry Message-ID: <20160816143628.GG20972@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Namhyung, Jiri, please take a look at the patch below, and Ack if possible, it is a problem introduced in: cfaa154b2335 ("perf tools: Get rid of obsolete hist_entry__sort_list") That is not equivalent to the code that was there and results in having the same entry as the first entry for the callchain as in the hist_entry, which is annoying and doesn't match the original intent of that 'continue' branch, as described in the comment right above it. Now looking at doing the same for the TUI... - Arnaldo diff --git a/tools/perf/ui/stdio/hist.c b/tools/perf/ui/stdio/hist.c index 9b65f4a6b35a..46a083e59ce9 100644 --- a/tools/perf/ui/stdio/hist.c +++ b/tools/perf/ui/stdio/hist.c @@ -207,7 +207,7 @@ static size_t callchain__fprintf_graph(FILE *fp, struct rb_root *root, * displayed twice. */ if (!i++ && field_order == NULL && - sort_order && !prefixcmp(sort_order, "sym")) + (sort_order == NULL || !prefixcmp(sort_order, "sym"))) continue; if (!printed) { ret += callchain__fprintf_left_margin(fp, left_margin);