From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753715AbcHPPsk (ORCPT ); Tue, 16 Aug 2016 11:48:40 -0400 Received: from mail-pf0-f173.google.com ([209.85.192.173]:34486 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753185AbcHPPsj (ORCPT ); Tue, 16 Aug 2016 11:48:39 -0400 Date: Wed, 17 Aug 2016 00:41:18 +0900 From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Arnaldo Carvalho de Melo , Jiri Olsa , Linux Kernel Mailing List Subject: Re: RFC: callchain showing same entry as hist_entry Message-ID: <20160816154118.GE11382@danjae.aot.lge.com> References: <20160816143628.GG20972@kernel.org> <20160816145511.GA11382@danjae.aot.lge.com> <20160816150803.GI20972@kernel.org> <20160816152355.GC11382@danjae.aot.lge.com> <20160816153143.GJ20972@kernel.org> <20160816153244.GK20972@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160816153244.GK20972@kernel.org> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 16, 2016 at 12:32:44PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Aug 16, 2016 at 12:31:43PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Wed, Aug 17, 2016 at 12:23:55AM +0900, Namhyung Kim escreveu: > > > Did you run 'perf report -s sym --stdio'? It seems that current code > > > already works as sane.. Do you want to make it work for the default sort > > >> key too? > > > > What I want is not to repeat the hist_entry line as the first entry in > > the callchain, which is confusing. > > > > I.e. repeat the duplication that is happening with the default sort > > s/repeat/remove/g > > > entry, that contains "sym". Hmm.. if so, wouldn't it be better skipping the first callchain entry when the user-given sort key contains "sym" too (not only when it starts with 'sym')? Thanks, Namhyung