From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753429AbcHPPrD (ORCPT ); Tue, 16 Aug 2016 11:47:03 -0400 Received: from mail.kernel.org ([198.145.29.136]:51728 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751584AbcHPPrC (ORCPT ); Tue, 16 Aug 2016 11:47:02 -0400 Date: Tue, 16 Aug 2016 12:46:57 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Jiri Olsa , Linux Kernel Mailing List Subject: Re: RFC: callchain showing same entry as hist_entry Message-ID: <20160816154657.GL20972@kernel.org> References: <20160816143628.GG20972@kernel.org> <20160816145511.GA11382@danjae.aot.lge.com> <20160816150803.GI20972@kernel.org> <20160816152355.GC11382@danjae.aot.lge.com> <20160816153143.GJ20972@kernel.org> <20160816153244.GK20972@kernel.org> <20160816154118.GE11382@danjae.aot.lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160816154118.GE11382@danjae.aot.lge.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Aug 17, 2016 at 12:41:18AM +0900, Namhyung Kim escreveu: > On Tue, Aug 16, 2016 at 12:32:44PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Aug 16, 2016 at 12:31:43PM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Wed, Aug 17, 2016 at 12:23:55AM +0900, Namhyung Kim escreveu: > > > > Did you run 'perf report -s sym --stdio'? It seems that current code > > > > already works as sane.. Do you want to make it work for the default sort > > > >> key too? > > > > > > What I want is not to repeat the hist_entry line as the first entry in > > > the callchain, which is confusing. > > > > > > I.e. repeat the duplication that is happening with the default sort > > > > s/repeat/remove/g > > > > > entry, that contains "sym". > > Hmm.. if so, wouldn't it be better skipping the first callchain entry > when the user-given sort key contains "sym" too (not only when it > starts with 'sym')? Probably, I think, whatever causes the mentioned duplication. And do that at all the UIs, hence the suggestion for a callchain__first_node() or more suitably named routine where such logic would live, to be used for all the callchain rendering interfaces. - Arnaldo