From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753185AbcHPRTH (ORCPT ); Tue, 16 Aug 2016 13:19:07 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:60247 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751443AbcHPRTG (ORCPT ); Tue, 16 Aug 2016 13:19:06 -0400 Date: Tue, 16 Aug 2016 09:31:50 -0700 From: Guenter Roeck To: Frank Wang Cc: heiko@sntech.de, kishon@ti.com, dianders@chromium.org, jwerner@chromium.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-rockchip@lists.infradead.org, xzy.xu@rock-chips.com, kever.yang@rock-chips.com, huangtao@rock-chips.com, william.wu@rock-chips.com, daniel.meng@rock-chips.com Subject: Re: [PATCH] phy: rockchip-inno-usb2: add COMMON_CLK dependency Message-ID: <20160816163150.GA28201@roeck-us.net> References: <1471327320-92871-1-git-send-email-frank.wang@rock-chips.com> <1471327320-92871-2-git-send-email-frank.wang@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1471327320-92871-2-git-send-email-frank.wang@rock-chips.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 16, 2016 at 02:02:00PM +0800, Frank Wang wrote: > On kernel builds without COMMON_CLK, the newly added rockchip-inno-usb2 > driver fails to build: > > drivers/phy/phy-rockchip-inno-usb2.c:124:16: error: field 'clk480m_hw' > has incomplete type > struct clk_hw clk480m_hw; > > In file included from include/linux/clk.h:16:0 > from drivers/phy/phy-rockchip-inno-usb2.c:17: > include/linux/kernel.h:831:48: error: initialization from incompatible > pointer type [-Werror=incompatible-pointer-types] > const typeof( ((type *)0)->member ) *__mptr = (ptr); \ > > ... ... > > Signed-off-by: Frank Wang > --- > drivers/phy/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index f9bf981..c6d57e5 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -370,6 +370,7 @@ config PHY_ROCKCHIP_USB > config PHY_ROCKCHIP_INNO_USB2 > tristate "Rockchip INNO USB2PHY Driver" > depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF > + depends on COMMON_CLK Wonder what is preferred here. I find 33 "select COMMON_CLK" and 18 "depends on COMMON_CLK". Either case Reviewed-by: Guenter Roeck > select GENERIC_PHY > help > Support for Rockchip USB2.0 PHY with Innosilicon IP block. > -- > 1.7.9.5 > >