From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753510AbcHPR3s (ORCPT ); Tue, 16 Aug 2016 13:29:48 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:36032 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751690AbcHPR3r (ORCPT ); Tue, 16 Aug 2016 13:29:47 -0400 Date: Tue, 16 Aug 2016 10:29:45 -0700 From: Stephen Boyd To: Neil Armstrong Cc: linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, mturquette@baylibre.com Subject: Re: [PATCH 1/3] clk: meson: Add GXBB AO Clock and Reset controller driver Message-ID: <20160816172945.GZ361@codeaurora.org> References: <1470734008-18849-1-git-send-email-narmstrong@baylibre.com> <1470734008-18849-2-git-send-email-narmstrong@baylibre.com> <20160813012910.GT361@codeaurora.org> <16163435-1310-043d-804f-3bb1fd33cff4@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16163435-1310-043d-804f-3bb1fd33cff4@baylibre.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/16, Neil Armstrong wrote: > On 08/13/2016 03:29 AM, Stephen Boyd wrote: > > On 08/09, Neil Armstrong wrote: > > >> + > >> +static struct clk_hw_onecell_data gxbb_aoclk_onecell_data = { > > > > can this be const? > > It would be awesome, but it will be discarded by of_clk_add_hw_provider : Ok, right. > >> +iounmap: > >> + iounmap(base); > >> + return ret; > >> +} > >> + > >> +static const struct of_device_id gxbb_aoclkc_match_table[] = { > >> + { .compatible = "amlogic,gxbb-aoclkc" }, > >> + { } > >> +}; > >> +MODULE_DEVICE_TABLE(of, gxbb_aoclkc_match_table); > >> + > >> +static struct platform_driver gxbb_aoclkc_driver = { > >> + .probe = gxbb_aoclkc_probe, > > > > No remove means leak of iomem mapping. And OF provider registration. > > > > It will be non-modular, so no need of remove. The MODULE_* macros and module.h include will be removed like other clk drivers (gxbb and oxnas for instance). Ok make sure to remove sysfs unbinding then. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project