From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753533AbcHPRb0 (ORCPT ); Tue, 16 Aug 2016 13:31:26 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:36282 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752344AbcHPRbZ (ORCPT ); Tue, 16 Aug 2016 13:31:25 -0400 Date: Tue, 16 Aug 2016 10:31:23 -0700 From: Stephen Boyd To: Geert Uytterhoeven Cc: Michael Turquette , "linux-kernel@vger.kernel.org" , linux-clk , Denis Efremov Subject: Re: [PATCH 2/2] clk: fixed-rate: Remove export symbol on setup function Message-ID: <20160816173123.GA361@codeaurora.org> References: <20160813015023.28221-1-sboyd@codeaurora.org> <20160813015023.28221-2-sboyd@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/16, Geert Uytterhoeven wrote: > Hi Stephen, > > On Sat, Aug 13, 2016 at 3:50 AM, Stephen Boyd wrote: > > This function is only called by builtin code, but we always > > exported it and had marked it as __init before commit > > e4eda8e0654c (clk: remove exported function from __init section, > > 2013-01-06) removed that marking. Given that it isn't used by > > modules, lets unexport it and add back __init. > > > > Cc: Denis Efremov > > Signed-off-by: Stephen Boyd > > --- > > drivers/clk/clk-fixed-rate.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/clk/clk-fixed-rate.c b/drivers/clk/clk-fixed-rate.c > > index c735272ed706..b5c46b3f8764 100644 > > --- a/drivers/clk/clk-fixed-rate.c > > +++ b/drivers/clk/clk-fixed-rate.c > > @@ -190,11 +190,10 @@ static struct clk *_of_fixed_clk_setup(struct device_node *node) > > /** > > * of_fixed_clk_setup() - Setup function for simple fixed rate clock > > */ > > -void of_fixed_clk_setup(struct device_node *node) > > +void __init of_fixed_clk_setup(struct device_node *node) > > { > > _of_fixed_clk_setup(node); > > } > > -EXPORT_SYMBOL_GPL(of_fixed_clk_setup); > > CLK_OF_DECLARE(fixed_clk, "fixed-clock", of_fixed_clk_setup); > > This function is needed to instantiate clocks from DT overlays, > which I'm using with out-of-tree "clk: add generic driver for fixed rate clock". > I think Ricardo's latest series should make that work for you with platform device drivers? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project