From: Keith Busch <keith.busch@intel.com>
To: J Freyensee <james_p_freyensee@linux.intel.com>
Cc: Helen Koike <helen.koike@collabora.co.uk>,
hch@infradead.org, mlin@kernel.org, fes@google.com,
rlnelson@google.com, axboe@fb.com, digitaleric@google.com,
tytso@mit.edu, mikew@google.com, monish@google.com,
open list <linux-kernel@vger.kernel.org>,
"open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
"Huffman, Amber" <amber.huffman@intel.com>,
"Minturn, Dave B" <dave.b.minturn@intel.com>
Subject: Re: [PATCH v3 RFC 2/2] nvme: improve performance for virtual NVMe devices
Date: Tue, 16 Aug 2016 23:45:08 +0000 [thread overview]
Message-ID: <20160816234508.GA12482@localhost.localdomain> (raw)
In-Reply-To: <1471380303.21107.38.camel@linux.intel.com>
On Tue, Aug 16, 2016 at 01:45:03PM -0700, J Freyensee wrote:
> On Mon, 2016-08-15 at 22:41 -0300, Helen Koike wrote:
> > struct nvmf_connect_command connect;
> > struct nvmf_property_set_command prop_set;
> > struct nvmf_property_get_command prop_get;
> > + struct nvme_doorbell_memory doorbell_memory;
> > };
> > };
>
> This looks like a new NVMe command being introduced, not found in the
> latest NVMe specs (NVMe 1.2.1 spec or NVMe-over-Fabrics 1.0 spec)?
>
> This is a big NACK, the command needs to be part of the NVMe standard
> before adding it to the NVMe code base (this is exactly how NVMe-over-
> Fabrics standard got implemented). I would bring your proposal to
> nvmexpress.org.
While this is an approved TPAR up for consideration soon, I don't think we
want to include this in mainline before it is ratified lest the current
form conflicts with the future spec.
We can still review and comment on the code, though it's not normally
done publicly until the spec is also public. The proposal originated
from a public RFC, though, so it's not a secret.
prev parent reply other threads:[~2016-08-16 23:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1460657059-21214-1-git-send-email-helen.koike@collabora.co.uk>
2016-08-16 1:41 ` [PATCH v3 RFC 0/2] Virtual NVMe device optimization Helen Koike
2016-08-16 1:41 ` [PATCH v3 RFC 1/2] PCI: Add Google device ID Helen Koike
2016-08-18 21:59 ` Bjorn Helgaas
2016-08-16 1:41 ` [PATCH v3 RFC 2/2] nvme: improve performance for virtual NVMe devices Helen Koike
2016-08-16 20:45 ` J Freyensee
2016-08-16 23:45 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160816234508.GA12482@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=amber.huffman@intel.com \
--cc=axboe@fb.com \
--cc=dave.b.minturn@intel.com \
--cc=digitaleric@google.com \
--cc=fes@google.com \
--cc=hch@infradead.org \
--cc=helen.koike@collabora.co.uk \
--cc=james_p_freyensee@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mikew@google.com \
--cc=mlin@kernel.org \
--cc=monish@google.com \
--cc=rlnelson@google.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox