From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753956AbcHQINw (ORCPT ); Wed, 17 Aug 2016 04:13:52 -0400 Received: from mga11.intel.com ([192.55.52.93]:9494 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753616AbcHQINt (ORCPT ); Wed, 17 Aug 2016 04:13:49 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,529,1464678000"; d="scan'208";a="1042616491" Date: Wed, 17 Aug 2016 11:13:44 +0300 From: Mika Westerberg To: Anisse Astier Cc: Linus Walleij , Heikki Krogerus , Yu C Chen , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe Message-ID: <20160817081344.GM30827@lahna.fi.intel.com> References: <1432281368-88687-1-git-send-email-mika.westerberg@linux.intel.com> <20150601092348.GK1747@lahna.fi.intel.com> <20150602141520.GE4057@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 16, 2016 at 06:12:40PM +0200, Anisse Astier wrote: > Hi Mika, > > On Tue, Jun 2, 2015 at 4:15 PM, Mika Westerberg > wrote: > > On Tue, Jun 02, 2015 at 03:53:40PM +0200, Linus Walleij wrote: > >> On Mon, Jun 1, 2015 at 11:23 AM, Mika Westerberg > >> wrote: > >> > On Fri, May 22, 2015 at 10:56:08AM +0300, Mika Westerberg wrote: > >> >> BIOS/platform may use some of the pins by themselves, such as providing SCI > >> >> (System Control Interrupt) from the embedded controller. The driver masks > >> >> all interrupts at probe time which prevents those pins from triggering > >> >> interrupts properly. > >> >> > >> >> Fix this by not masking all interrupts at probe -- it should be enough just > >> >> to clear the status register. > >> >> > >> >> Reported-by: Yu C Chen > >> >> Signed-off-by: Mika Westerberg > >> > > >> > Please ignore this patch for now. It turned out to be causing spurious > >> > interrupts on another platform. > >> > > >> > I'll need to rethink how to fix the reported issue. > >> > >> Looks like a case of "embed more magic knowledge" in the driver :/ > >> > >> It needs to know what platform it is running on, and only leave specific > >> bits unmasked on these specific platforms. Right? Thereby > >> tossing all of the acpi_device_id matching and abstraction out > >> of the window. > > > > That's right. > > > > We still have few options left, like using ACPI _AEI (ACPI GPIO > > triggered events) for this or adding GPIO interrupt support directly to > > the EC driver. > > Did you find a way to fix this issue ? I'm seeing a similar problem on a > laptop where this masks the interrupt used for ACPI events (brightness, > lid, battery). I seem to have forgotten this completely :-/ Can you send me output of /sys/kernel/debug/pinctrl/INT33FF:*/pins for that particular EC pin? In addition if you apply this patch do you see that ACPI events start working?