From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752690AbcHQLV6 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 17 Aug 2016 07:21:58 -0400
Received: from mail-wm0-f67.google.com ([74.125.82.67]:34344 "EHLO
	mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751688AbcHQLV4 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 17 Aug 2016 07:21:56 -0400
Date: Wed, 17 Aug 2016 13:21:50 +0200
From: Daniel Vetter <daniel@ffwll.ch>
To: Colin King <colin.king@canonical.com>
Cc: Xinliang Liu <z.liuxinliang@hisilicon.com>,
        Xinwei Kong <kong.kongxinwei@hisilicon.com>,
        Chen Feng <puck.chen@hisilicon.com>, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        Eric Engestrom <eric.engestrom@imgtec.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/hisilicon: add back missing } on ade_dc_ops
Message-ID: <20160817112150.GW6232@phenom.ffwll.local>
Mail-Followup-To: Colin King <colin.king@canonical.com>,
	Xinliang Liu <z.liuxinliang@hisilicon.com>,
	Xinwei Kong <kong.kongxinwei@hisilicon.com>,
	Chen Feng <puck.chen@hisilicon.com>,
	David Airlie <airlied@linux.ie>,
	Eric Engestrom <eric.engestrom@imgtec.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <1471432164-84308-1-git-send-email-colin.king@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1471432164-84308-1-git-send-email-colin.king@canonical.com>
X-Operating-System: Linux phenom 4.6.0-1-amd64 
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 17, 2016 at 12:09:24PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Fix build error by adding back the closing } on ade_dc_ops which
> got accidentally removed from an earlier commit.
> 
> Fixes: d25bcfb8c2e18b9b36 ("Don't set drm_device->platformdev")

Yeah that patch was horribly screwed up, but at least in my testing
there's more broken with it. Does this really fix it?
-Daniel

> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> index 91188f3..c9f8166 100644
> --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> @@ -1062,4 +1062,4 @@ static void ade_drm_cleanup(struct platform_device *pdev)
>  const struct kirin_dc_ops ade_dc_ops = {
>  	.init = ade_drm_init,
>  	.cleanup = ade_drm_cleanup
> -;
> +};
> -- 
> 2.9.3
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch