From: Al Viro <viro@ZenIV.linux.org.uk>
To: zijun_hu <zijun_hu@zoho.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH 1/1] bitops.h: move out get_count_order[_long]() from __KERNEL__ scope
Date: Wed, 17 Aug 2016 18:20:56 +0100 [thread overview]
Message-ID: <20160817172056.GE2356@ZenIV.linux.org.uk> (raw)
In-Reply-To: <57B2C4CE.80303@zoho.com>
On Tue, Aug 16, 2016 at 03:46:22PM +0800, zijun_hu wrote:
> From: zijun_hu <zijun_hu@htc.com>
>
> move out get_count_order[_long]() definitions from scope limited
> by macro __KERNEL__
>
> it not only make both functions available in wider region regardless
> of whether __KERNEL__ is defined but also keep original region for
> get_count_order() before the recent commit c513b4cd2fe9
> ("mm-vmalloc-fix-align-value-calculation-error-v2-fix-fix")
What the hell is anything without __KERNEL__ doing with linux/bitops.h in
the first place? IOW, why do we have those ifdefs at all?
next prev parent reply other threads:[~2016-08-17 17:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 6:27 [PATCH 1/1] bitops.h: move out get_count_order[_long]() from __KERNEL__ scope zijun_hu
2016-08-16 6:50 ` Stephen Rothwell
2016-08-16 7:24 ` zijun_hu
2016-08-16 7:46 ` [RESEND PATCH " zijun_hu
2016-08-17 17:20 ` Al Viro [this message]
2016-08-17 23:51 ` zijun_hu
2016-08-17 23:59 ` Al Viro
2016-08-18 0:10 ` zijun_hu
2016-08-18 0:28 ` Al Viro
2016-08-18 0:50 ` zijun_hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160817172056.GE2356@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=zijun_hu@zoho.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox