From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753000AbcHQRV3 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 17 Aug 2016 13:21:29 -0400
Received: from zeniv.linux.org.uk ([195.92.253.2]:34054 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752475AbcHQRV0 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 17 Aug 2016 13:21:26 -0400
Date: Wed, 17 Aug 2016 18:20:56 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: zijun_hu <zijun_hu@zoho.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
        Andrew Morton <akpm@linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH 1/1] bitops.h: move out get_count_order[_long]()
 from __KERNEL__ scope
Message-ID: <20160817172056.GE2356@ZenIV.linux.org.uk>
References: <57B2B238.3030709@zoho.com>
 <57B2C4CE.80303@zoho.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <57B2C4CE.80303@zoho.com>
User-Agent: Mutt/1.6.1 (2016-04-27)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 16, 2016 at 03:46:22PM +0800, zijun_hu wrote:
> From: zijun_hu <zijun_hu@htc.com>
> 
> move out get_count_order[_long]() definitions from scope limited
> by macro __KERNEL__
> 
> it not only make both functions available in wider region regardless
> of whether __KERNEL__ is defined but also keep original region for
> get_count_order() before the recent commit c513b4cd2fe9
> ("mm-vmalloc-fix-align-value-calculation-error-v2-fix-fix") 

What the hell is anything without __KERNEL__ doing with linux/bitops.h in
the first place?  IOW, why do we have those ifdefs at all?