From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753057AbcHQSTj (ORCPT ); Wed, 17 Aug 2016 14:19:39 -0400 Received: from mga02.intel.com ([134.134.136.20]:46408 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752488AbcHQSTh (ORCPT ); Wed, 17 Aug 2016 14:19:37 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,535,1464678000"; d="scan'208";a="1027160394" Date: Wed, 17 Aug 2016 12:07:22 -0600 From: Ross Zwisler To: Jan Kara Cc: Ross Zwisler , linux-kernel@vger.kernel.org, "Theodore Ts'o" , Andreas Dilger , Dan Williams , Jan Kara , linux-ext4@vger.kernel.org, linux-nvdimm@ml01.01.org Subject: Re: [PATCH] ext4: allow DAX writeback for hole punch Message-ID: <20160817180722.GB16779@linux.intel.com> References: <20160817161102.2185-1-ross.zwisler@linux.intel.com> <20160817171955.GA30893@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160817171955.GA30893@quack2.suse.cz> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 17, 2016 at 07:19:55PM +0200, Jan Kara wrote: > On Wed 17-08-16 10:11:02, Ross Zwisler wrote: > > Currently when doing a DAX hole punch with ext4 we fail to do a writeback. > > This is because the logic around filemap_write_and_wait_range() in > > ext4_punch_hole() only looks for dirty page cache pages in the radix tree, > > not for dirty DAX exceptional entries. > > > > Signed-off-by: Ross Zwisler > > Thanks. The patch looks correct, you can add: > > Reviewed-by: Jan Kara > > Although why don't we just simplify the test below to > mapping_tagged(mapping, PAGECACHE_TAG_DIRTY)? After all the mapping should > not have the dirty tag set if there are no pages / no entries? Sure, that works. I'll update to that in V2, and I'll add stable. Thanks!