From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752993AbcHQURj (ORCPT ); Wed, 17 Aug 2016 16:17:39 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:59001 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752435AbcHQURi (ORCPT ); Wed, 17 Aug 2016 16:17:38 -0400 Date: Wed, 17 Aug 2016 13:17:36 -0700 From: Stephen Boyd To: Kees Cook Cc: "Paul E . McKenney" , Laura Abbott , Steven Rostedt , Daniel Micay , Joe Perches , Arnd Bergmann , Greg Kroah-Hartman , Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , "Aneesh Kumar K.V" , "Kirill A. Shutemov" , Michael Ellerman , Dan Williams , Andrew Morton , Ingo Molnar , Thomas Gleixner , Josef Bacik , Andrey Ryabinin , Tejun Heo , Nikolay Aleksandrov , Dmitry Vyukov , linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com Subject: Re: [PATCH v2 0/5] bug: Provide toggle for BUG on data corruption Message-ID: <20160817201736.GB361@codeaurora.org> References: <1471393229-27182-1-git-send-email-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1471393229-27182-1-git-send-email-keescook@chromium.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/16, Kees Cook wrote: > This adds a CONFIG to trigger BUG()s when the kernel encounters > unexpected data structure integrity as currently detected with > CONFIG_DEBUG_LIST. > > Specifically list operations have been a target for widening flaws to gain > "write anywhere" primitives for attackers, so this also consolidates the > debug checking to avoid code and check duplication (e.g. RCU list debug > was missing a check that got added to regular list debug). It also stops > manipulations when corruption is detected, since worsening the corruption > makes no sense. (Really, everyone should build with CONFIG_DEBUG_LIST > since the checks are so inexpensive.) > > This is mostly a refactoring of similar code from PaX and Grsecurity, > along with MSM kernel changes by Stephen Boyd. Which commit in the MSM kernel from me? I wonder if perhaps you're thinking of a patch from Syed Rameez Mustafa like commit 1c014f321e6d67f47 in the msm-3.4 kernel. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project