From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1945897AbcHRARf (ORCPT <rfc822;w@1wt.eu>);
	Wed, 17 Aug 2016 20:17:35 -0400
Received: from mail-pa0-f66.google.com ([209.85.220.66]:33835 "EHLO
	mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753180AbcHRARd (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 17 Aug 2016 20:17:33 -0400
Date: Thu, 18 Aug 2016 07:00:58 +0800
From: Peter Chen <hzpeterchen@gmail.com>
To: Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        Guenter Roeck <linux@roeck-us.net>, Oliver Neukum <oneukum@suse.com>,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v5 2/2] usb: typec: add driver for Intel Whiskey Cove
 PMIC USB Type-C PHY
Message-ID: <20160817230058.GA26420@shlinux2>
References: <1471430081-12860-1-git-send-email-heikki.krogerus@linux.intel.com>
 <1471430081-12860-3-git-send-email-heikki.krogerus@linux.intel.com>
 <87d1l77e0r.fsf@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87d1l77e0r.fsf@linux.intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 17, 2016 at 03:53:24PM +0300, Felipe Balbi wrote:
> 
> Hi,
> 
> Heikki Krogerus <heikki.krogerus@linux.intel.com> writes:
> 
> [...]
> 
> > +static struct platform_driver wcove_typec_driver = {
> > +	.driver = {
> > +		.name		= "bxt_wcove_usbc",
> > +	},
> > +	.probe			= wcove_typec_probe,
> > +	.remove			= wcove_typec_remove,
> > +};
> > +
> > +module_platform_driver(wcove_typec_driver);
> > +
> > +MODULE_AUTHOR("Intel Corporation");
> > +MODULE_LICENSE("GPL v2");
> > +MODULE_DESCRIPTION("WhiskeyCove PMIC USB Type-C PHY driver");
> 
> you need to add:
> 
> MODULE_ALIAS("platform:bxt_wcove_usbc");
> 
> otherwise this won't probe() automagically.
> 

What do you mean, Felipe? If there is a platform device named
"bxt_wcove_usbc", why it will not be probed?

-- 

Best Regards,
Peter Chen