From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946019AbcHRJri (ORCPT ); Thu, 18 Aug 2016 05:47:38 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:36278 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1945906AbcHRJrf (ORCPT ); Thu, 18 Aug 2016 05:47:35 -0400 Date: Thu, 18 Aug 2016 11:47:30 +0200 From: Ingo Molnar To: Wei Jiangang Cc: linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, bp@suse.de Subject: Re: [PATCH 1/2] x86/smpboot: Check APIC ID before setting up default routing Message-ID: <20160818094730.GA1967@gmail.com> References: <1471416172-9463-1-git-send-email-weijg.fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1471416172-9463-1-git-send-email-weijg.fnst@cn.fujitsu.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Wei Jiangang wrote: > Check the boot APIC ID firstly, > and then setup the default routing of APIC looks better. > > And move default_setup_apic_routing() close to apic_bsp_setup(), > which staying in step with the codes in APIC_init_uniprocessor(). > > Signed-off-by: Wei Jiangang > --- > arch/x86/kernel/smpboot.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) If it's not a bug then please clearly note so in the changelog and explain why the change results in better code. If it's fixing a bug/misfeature then please fix the changelog to conform to the standard changelog style: - first describe the symptoms of the bug - how does a user notice? - then describe how the code behaves today and how that is causing the bug - and then only describe how it's fixed. Thanks, Ingo