From: Jonathan Corbet <corbet@lwn.net>
To: Zhou Wenjian <zhouwj-fnst@cn.fujitsu.com>
Cc: <linux-kernel@vger.kernel.org>, <akpm@linux-foundation.org>,
<dyoung@redhat.com>, <bhe@redhat.com>, <vgoyal@redhat.com>,
<kexec@lists.infradead.org>, <linux-doc@vger.kernel.org>,
<xlpang@redhat.com>, <joe@perches.com>
Subject: Re: [PATCH v9 1/2] Documentation: kdump: remind user of nr_cpus
Date: Thu, 18 Aug 2016 11:18:54 -0600 [thread overview]
Message-ID: <20160818111854.362bb972@lwn.net> (raw)
In-Reply-To: <1471489907-27737-2-git-send-email-zhouwj-fnst@cn.fujitsu.com>
On Thu, 18 Aug 2016 11:11:46 +0800
Zhou Wenjian <zhouwj-fnst@cn.fujitsu.com> wrote:
Thank you for working to improve the documentation!
> * We generally don' have to bring up a SMP kernel just to capture the
> dump. Hence generally it is useful either to build a UP dump-capture
> kernel or specify maxcpus=1 option while loading dump-capture kernel.
> + Note, though maxcpus always works, you should replace it by nr_cpus to
> + save memory if supported by the current ARCH, such as x86.
So, IMHO, this seems like the wrong place for this. I've just spent a bit
of time staring at kernel-parameters.txt, and there is no way for a
clueless user like me to know what the difference is between maxcpus= and
nr_cpus= would be. A far better patch would be to update the
documentation there to make that clear. Any chance you would be willing
to do that?
Then, rather than tacking an "ignore what you just read" note into
kdump.txt, it could maybe be rewritten to simply say what users should do?
Thanks,
jon
next prev parent reply other threads:[~2016-08-19 0:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 3:11 [PATCH v9 0/2] update the doc of kdump Zhou Wenjian
2016-08-18 3:11 ` [PATCH v9 1/2] Documentation: kdump: remind user of nr_cpus Zhou Wenjian
2016-08-18 17:18 ` Jonathan Corbet [this message]
2016-08-19 0:33 ` "Zhou, Wenjian/周文剑"
2016-08-19 15:57 ` Jonathan Corbet
2016-08-22 1:14 ` "Zhou, Wenjian/周文剑"
2016-08-24 5:06 ` Baoquan He
2016-08-25 19:10 ` Jonathan Corbet
2016-08-27 0:35 ` Baoquan He
2016-08-26 0:45 ` "Zhou, Wenjian/周文剑"
2016-08-27 0:38 ` Baoquan He
2016-08-18 3:11 ` [PATCH v9 2/2] Documentation: kdump: add description of enable multi-cpus support Zhou Wenjian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160818111854.362bb972@lwn.net \
--to=corbet@lwn.net \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=joe@perches.com \
--cc=kexec@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
--cc=xlpang@redhat.com \
--cc=zhouwj-fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox