From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1767376AbcHRN6Y (ORCPT ); Thu, 18 Aug 2016 09:58:24 -0400 Received: from mga09.intel.com ([134.134.136.24]:54511 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946827AbcHRN6W (ORCPT ); Thu, 18 Aug 2016 09:58:22 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,539,1464678000"; d="scan'208";a="867607758" Date: Thu, 18 Aug 2016 16:58:13 +0300 From: Mika Westerberg To: Anisse Astier Cc: Linus Walleij , Heikki Krogerus , Yu C Chen , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe Message-ID: <20160818135813.GJ30827@lahna.fi.intel.com> References: <1432281368-88687-1-git-send-email-mika.westerberg@linux.intel.com> <20150601092348.GK1747@lahna.fi.intel.com> <20150602141520.GE4057@lahna.fi.intel.com> <20160817081344.GM30827@lahna.fi.intel.com> <20160818121328.GE30827@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 18, 2016 at 03:52:57PM +0200, Anisse Astier wrote: > On Thu, Aug 18, 2016 at 2:13 PM, Mika Westerberg > wrote: > > On Wed, Aug 17, 2016 at 03:42:58PM +0200, Anisse Astier wrote: > >> pin 25 (GPIO_SUS6) GPIO ctrl0 0xec918201 ctrl1 0x05c00001 > > > > It is this one (GPIO_SUS6). > > > > I wonder if we can relax the driver so that it only masks pins which are > > not configured to generate interrupts by the BIOS. I quickly tried > > following on one Braswell machine and it did not generate spurious > > interrupts. > > > > Can you check if this works for you? > > I tried it, your patch is working. It gives the same result as not > clearing the north community. I receive the ACPI events. OK, thanks for testing. I'll make a formal patch and submit it with you CC'd. Let's hope it will not break anything :)