From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755033AbcHSBh3 (ORCPT ); Thu, 18 Aug 2016 21:37:29 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:34502 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754334AbcHSBdE (ORCPT ); Thu, 18 Aug 2016 21:33:04 -0400 Date: Thu, 18 Aug 2016 12:44:43 -0700 From: Bjorn Andersson To: Corentin LABBE Cc: ohad@wizery.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH RFC 1/3] hwspinlock: sun8i: add Allwinner sun8i HardWare Spinlock Message-ID: <20160818194443.GX26240@tuxbot> References: <1471002394-1106-1-git-send-email-clabbe.montjoie@gmail.com> <20160812190641.GI26240@tuxbot> <0a17ceec-13f7-ddeb-69dd-2505154e8ccf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0a17ceec-13f7-ddeb-69dd-2505154e8ccf@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 18 Aug 12:38 PDT 2016, Corentin LABBE wrote: > Hello > > Thanks for your review, I will fix all your reports for next version. > > On 12/08/2016 21:06, Bjorn Andersson wrote: > > On Fri 12 Aug 04:46 PDT 2016, LABBE Corentin wrote: > > > >> Add hwspinlock support for the Allwinner Hardware Spinlock device > >> present on the A83T, H3 and A64 SoCs. > >> > >> This Hardware Spinlock device provides hardware assistance > >> for synchronization between the multiple processors in the system. > >> > > [..] > >> + goto clk_fail; > >> + } > >> + > >> + dev_info(&pdev->dev, "Sun8i hwspinlock driver loaded with %d locks\n", > >> + priv->num_locks); > > > > Please don't advertise the driver on success. > > > > I was doing that because datasheet specify only 32 slot, but later a register give a possibility of more slots. > Perhaps its better to advertise only for uncommon hardware (slot > 32) ? > I see, well that would be useful for developers to see, how about you just make it dev_dbg? That way one would be a command line addition [1] away from getting the information out. [1] dyndbg="module sun8i_hwspinlock +p" Regards, Bjorn