From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754423AbcHSDfC (ORCPT <rfc822;w@1wt.eu>);
        Thu, 18 Aug 2016 23:35:02 -0400
Received: from mga02.intel.com ([134.134.136.20]:36059 "EHLO mga02.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752904AbcHSDfA (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 18 Aug 2016 23:35:00 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,543,1464678000"; 
   d="scan'208";a="1028125072"
Date: Fri, 19 Aug 2016 09:12:50 +0530
From: Vinod Koul <vinod.koul@intel.com>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>,
        linux-arm-msm@vger.kernel.org, timur@codeaurora.org,
        linux-kernel@vger.kernel.org,
        Christopher Covington <cov@codeaurora.org>, dmaengine@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dmaengine: qcom_hidma: release the descriptor before the
 callback
Message-ID: <20160819034249.GS9681@localhost>
References: <20160804125525.GF9681@localhost>
 <71a15611-645f-7523-1c26-14b420aff667@codeaurora.org>
 <20160804144003.GV1041@n2100.armlinux.org.uk>
 <cff588a1-d85f-3d2c-ef61-1674d0d3ca92@codeaurora.org>
 <20160808090203.GY9681@localhost>
 <21475c6e-a5f8-5125-3998-f3995ce67c4d@codeaurora.org>
 <20160810172805.GH9681@localhost>
 <d09ebb5f-99ea-a4e9-da9c-693be89c7cd4@codeaurora.org>
 <20160819024853.GR9681@localhost>
 <8c096fee-9749-a7df-7e04-25d21c0ea9ac@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8c096fee-9749-a7df-7e04-25d21c0ea9ac@codeaurora.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 18, 2016 at 11:26:28PM -0400, Sinan Kaya wrote:
> On 8/18/2016 10:48 PM, Vinod Koul wrote:
> >> Keep a size limited list with error cookies and flush them in terminate all?
> > I think so, terminate_all anyway cleans up the channel. Btw what is the
> > behaviour on error? Do you terminate or somthing else?
> > 
> 
> On error, I flush all outstanding transactions with an error code and I reset
> the channel. After the reset, the DMA channel is functional again. The client
> doesn't need to shutdown anything.

You mean from the client context or driver?

-- 
~Vinod