From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754671AbcHSKZz (ORCPT ); Fri, 19 Aug 2016 06:25:55 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:36352 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754144AbcHSKZy (ORCPT ); Fri, 19 Aug 2016 06:25:54 -0400 Date: Fri, 19 Aug 2016 12:25:51 +0200 From: Michal Hocko To: Xie Yisheng Cc: akpm@linux-foundation.org, guohanjun@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] arm64/hugetlb enable gigantic hugepage Message-ID: <20160819102551.GA32632@dhcp22.suse.cz> References: <1471521929-9207-1-git-send-email-xieyisheng1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1471521929-9207-1-git-send-email-xieyisheng1@huawei.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 18-08-16 20:05:29, Xie Yisheng wrote: > As we know, arm64 also support gigantic hugepage eg. 1G. Well, I do not know that. How can I check? Anyway to the patch [...] > index 87e11d8..b4d8048 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -1022,7 +1022,8 @@ static int hstate_next_node_to_free(struct hstate *h, nodemask_t *nodes_allowed) > ((node = hstate_next_node_to_free(hs, mask)) || 1); \ > nr_nodes--) > > -#if (defined(CONFIG_X86_64) || defined(CONFIG_S390)) && \ > +#if (defined(CONFIG_X86_64) || defined(CONFIG_S390) || \ > + defined(CONFIG_ARM64)) && \ > ((defined(CONFIG_MEMORY_ISOLATION) && defined(CONFIG_COMPACTION)) || \ > defined(CONFIG_CMA)) this ifdef is getting pretty unwieldy. For one thing I think that respective archs should enable ARCH_HAVE_GIGANTIC_PAGES. > static void destroy_compound_gigantic_page(struct page *page, > -- > 1.7.12.4 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- Michal Hocko SUSE Labs