Re: [PART2 PATCH v6 12/12] svm: Implements update_pi_irte hook to setup posted interrupt

Radim Krčmář
2016-08-19T15:04:54Z

2016-08-19 16:49+0200, Radim Krčmář:
> Minor design note:
> To make the usage of "struct amd_ir_data" safer, we could pass "struct
> list_head" into irq_set_vcpu_affinity(), instead of returning "struct
> amd_ir_data *".
>
> irq_set_vcpu_affinity() would add "struct amd_ir_data" to the list only
> if ir_data was not already in some list and report whether the list
> was modified.

No, this would not simplify the search. An important point of list_head
in amd_ir_data was to let us know the current list.