From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755335AbcHSPwA (ORCPT ); Fri, 19 Aug 2016 11:52:00 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:34051 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754778AbcHSPvz (ORCPT ); Fri, 19 Aug 2016 11:51:55 -0400 Date: Fri, 19 Aug 2016 17:51:40 +0200 From: Krzysztof Kozlowski To: Javier Martinez Canillas Cc: Krzysztof Kozlowski , linux-kernel@vger.kernel.org, Arnd Bergmann , Olof Johansson , linux-arm-kernel@lists.infradead.org, arm@kernel.org Subject: Re: [PATCH 2/2] ARM: multi_v7_defconfig: Don't attempt to enable schedutil governor as module Message-ID: <20160819155140.GA12633@kozik-lap> References: <1471612328-6467-1-git-send-email-javier@osg.samsung.com> <1471612328-6467-2-git-send-email-javier@osg.samsung.com> <9c71ddbd-deb1-1e07-7421-53bb58359bad@kernel.org> <7dd6278d-bdc4-14e5-6b2e-062a59cd29d4@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 19, 2016 at 09:52:47AM -0400, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 08/19/2016 09:46 AM, Javier Martinez Canillas wrote: > > > > On 08/19/2016 09:40 AM, Krzysztof Kozlowski wrote: > >> On 08/19/2016 03:12 PM, Javier Martinez Canillas wrote: > >>> The schedutil CPUFreq governor could be built as a module but the commit > >>> 58919e83c85c ("cpufreq / sched: Pass flags to cpufreq_update_util()") > >>> made it non-modular so attempting to enable as module leads to a warning: > >>> > >>> warning: symbol value 'm' invalid for CPU_FREQ_GOV_SCHEDUTIL > >>> > >>> Signed-off-by: Javier Martinez Canillas > >>> > >>> --- > >>> > >>> arch/arm/configs/multi_v7_defconfig | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> Looks good. > >> > >> Applied... wait, no, these are not in samsung-soc list so they miss also > >> from patchwork. For reference: > >> Reviewed-by: Krzysztof Kozlowski > >> > > > > Sigh, get_maintainers.pl suggested me an insanely large cc list so I added > > it manually... but I forgot linux-samsung-soc. I'll post v2. > > > > Damn... and now I forgot to include your collected tags in v2. I should not > post patches before having enough coffee, sorry about that. > > Please let me know if you don't mind or if you prefer a resend. No problem, no need to resend. Applied to separate branch (not tagged yet) in case someone would like to base on top of it. Then please let me know, I'll add a tag. Mentioned commit is not yet in mainline and was applied recently, so I remove the SHA from commit msg. The SHA might change and it's better not to pollute the history in that case. Best regards, Krzysztof