From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Matthew Wilcox <mawilcox@linuxonhyperv.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
linux-nvdimm@ml01.01.org, Matthew Wilcox <mawilcox@microsoft.com>
Subject: Re: [PATCH 1/2] x86: Set up resources correctly on Hyper-V Generation 2
Date: Fri, 19 Aug 2016 12:06:51 -0400 [thread overview]
Message-ID: <20160819160651.GA7478@char.us.oracle.com> (raw)
In-Reply-To: <1471547575-14748-1-git-send-email-mawilcox@linuxonhyperv.com>
On Thu, Aug 18, 2016 at 12:12:54PM -0700, Matthew Wilcox wrote:
> From: Matthew Wilcox <mawilcox@microsoft.com>
>
> The Generation 2 Hyper-V virtual machine does not emulate PCI.
> This check causes the call to pcibios_resource_survey() to be skipped,
> and pcibios_resource_survey() calls e820_reserve_resources_late(), which
> is where PMEM resources are added to the resource tree. With this patch,
> the PMEM devices now show up.
>
> Signed-off-by: Matthew Wilcox <mawilcox@microsoft.com>
> ---
> arch/x86/pci/common.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c
> index 7b6a9d1..d39e799 100644
> --- a/arch/x86/pci/common.c
> +++ b/arch/x86/pci/common.c
> @@ -516,11 +516,6 @@ void __init pcibios_set_cache_line_size(void)
>
> int __init pcibios_init(void)
> {
> - if (!raw_pci_ops && !raw_pci_ext_ops) {
> - printk(KERN_WARNING "PCI: System does not support PCI\n");
> - return 0;
> - }
So shouldn't this be gated on whether the platform is HyperV?
> -
> pcibios_set_cache_line_size();
> pcibios_resource_survey();
>
> --
> 2.8.1
>
> _______________________________________________
> Linux-nvdimm mailing list
> Linux-nvdimm@lists.01.org
> https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2016-08-19 16:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 19:12 [PATCH 1/2] x86: Set up resources correctly on Hyper-V Generation 2 Matthew Wilcox
2016-08-18 17:31 ` Dan Williams
2016-08-18 17:50 ` Matthew Wilcox
2016-08-18 18:02 ` Dan Williams
2016-08-18 18:05 ` Matthew Wilcox
2016-08-18 18:15 ` Dan Williams
2016-08-18 18:26 ` Matthew Wilcox
2016-08-18 19:12 ` Dan Williams
2016-08-18 19:56 ` Matthew Wilcox
2016-08-18 20:16 ` Dan Williams
2016-08-18 21:26 ` Matthew Wilcox
2016-08-18 19:12 ` [PATCH 2/2] x86: Turn down the scary 'no PCI' warning Matthew Wilcox
2016-08-19 16:06 ` Konrad Rzeszutek Wilk [this message]
2016-08-19 16:46 ` [PATCH 1/2] x86: Set up resources correctly on Hyper-V Generation 2 Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160819160651.GA7478@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=mawilcox@linuxonhyperv.com \
--cc=mawilcox@microsoft.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox