From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754010AbcHTSUJ (ORCPT ); Sat, 20 Aug 2016 14:20:09 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:56747 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753771AbcHTSUI (ORCPT ); Sat, 20 Aug 2016 14:20:08 -0400 X-IBM-Helo: d03dlp01.boulder.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com Date: Sat, 20 Aug 2016 11:20:13 -0700 From: "Paul E. McKenney" To: Valentin Rothberg Cc: keescook@chromium.org, rostedt@goodmis.org, linux-kernel@vger.kernel.org, pebolle@tiscali.nl, ziegler@cs.fau.de Subject: Re: [PATCH] lib/Kconfig.debug: fix typo in select statement Reply-To: paulmck@linux.vnet.ibm.com References: <20160820101610.53184-1-valentinrothberg@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160820101610.53184-1-valentinrothberg@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16082018-0008-0000-0000-0000055BBB08 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005619; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000183; SDB=6.00747307; UDB=6.00352500; IPR=6.00519904; BA=6.00004671; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00012405; XFM=3.00000011; UTC=2016-08-20 18:20:06 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16082018-0009-0000-0000-00003A6B93E8 Message-Id: <20160820182013.GN3482@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-20_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608200240 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 20, 2016 at 12:16:10PM +0200, Valentin Rothberg wrote: > Commit 484f29c7430b3 ("bug: Provide toggle for BUG on data corruption") > added a Kconfig select statement on CONFIG_DEBUG_LIST, but the CONFIG_ > prefix is only used in Make and C(PP) syntax. Remove the CONFIG_ prefix > to correctly select the Kconfig option DEBUG_LIST. > > Signed-off-by: Valentin Rothberg Well, color me blind! Good catch, queued for review and testing. Kees, Steve, Rik, any objections? Thanx, Paul > --- > I detected the issue with scripts/checkkconfigsymbols.py > > lib/Kconfig.debug | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index 5dea4d0a5a07..c2bbaae13d04 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -2009,7 +2009,7 @@ config TEST_STATIC_KEYS > > config BUG_ON_DATA_CORRUPTION > bool "Trigger a BUG when data corruption is detected" > - select CONFIG_DEBUG_LIST > + select DEBUG_LIST > help > Select this option if the kernel should BUG when it encounters > data corruption in kernel memory structures when they get checked > -- > 2.9.3 >