* [PATCH] lib/Kconfig.debug: fix typo in select statement
@ 2016-08-20 10:16 Valentin Rothberg
2016-08-20 18:20 ` Paul E. McKenney
0 siblings, 1 reply; 3+ messages in thread
From: Valentin Rothberg @ 2016-08-20 10:16 UTC (permalink / raw)
To: keescook, rostedt, paulmck
Cc: linux-kernel, pebolle, ziegler, Valentin Rothberg
Commit 484f29c7430b3 ("bug: Provide toggle for BUG on data corruption")
added a Kconfig select statement on CONFIG_DEBUG_LIST, but the CONFIG_
prefix is only used in Make and C(PP) syntax. Remove the CONFIG_ prefix
to correctly select the Kconfig option DEBUG_LIST.
Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
---
I detected the issue with scripts/checkkconfigsymbols.py
lib/Kconfig.debug | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 5dea4d0a5a07..c2bbaae13d04 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -2009,7 +2009,7 @@ config TEST_STATIC_KEYS
config BUG_ON_DATA_CORRUPTION
bool "Trigger a BUG when data corruption is detected"
- select CONFIG_DEBUG_LIST
+ select DEBUG_LIST
help
Select this option if the kernel should BUG when it encounters
data corruption in kernel memory structures when they get checked
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] lib/Kconfig.debug: fix typo in select statement 2016-08-20 10:16 [PATCH] lib/Kconfig.debug: fix typo in select statement Valentin Rothberg @ 2016-08-20 18:20 ` Paul E. McKenney 2016-08-21 3:24 ` Kees Cook 0 siblings, 1 reply; 3+ messages in thread From: Paul E. McKenney @ 2016-08-20 18:20 UTC (permalink / raw) To: Valentin Rothberg; +Cc: keescook, rostedt, linux-kernel, pebolle, ziegler On Sat, Aug 20, 2016 at 12:16:10PM +0200, Valentin Rothberg wrote: > Commit 484f29c7430b3 ("bug: Provide toggle for BUG on data corruption") > added a Kconfig select statement on CONFIG_DEBUG_LIST, but the CONFIG_ > prefix is only used in Make and C(PP) syntax. Remove the CONFIG_ prefix > to correctly select the Kconfig option DEBUG_LIST. > > Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com> Well, color me blind! Good catch, queued for review and testing. Kees, Steve, Rik, any objections? Thanx, Paul > --- > I detected the issue with scripts/checkkconfigsymbols.py > > lib/Kconfig.debug | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index 5dea4d0a5a07..c2bbaae13d04 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -2009,7 +2009,7 @@ config TEST_STATIC_KEYS > > config BUG_ON_DATA_CORRUPTION > bool "Trigger a BUG when data corruption is detected" > - select CONFIG_DEBUG_LIST > + select DEBUG_LIST > help > Select this option if the kernel should BUG when it encounters > data corruption in kernel memory structures when they get checked > -- > 2.9.3 > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] lib/Kconfig.debug: fix typo in select statement 2016-08-20 18:20 ` Paul E. McKenney @ 2016-08-21 3:24 ` Kees Cook 0 siblings, 0 replies; 3+ messages in thread From: Kees Cook @ 2016-08-21 3:24 UTC (permalink / raw) To: Paul McKenney Cc: Valentin Rothberg, Steven Rostedt, LKML, Paul Bolle, ziegler On Sat, Aug 20, 2016 at 11:20 AM, Paul E. McKenney <paulmck@linux.vnet.ibm.com> wrote: > On Sat, Aug 20, 2016 at 12:16:10PM +0200, Valentin Rothberg wrote: >> Commit 484f29c7430b3 ("bug: Provide toggle for BUG on data corruption") >> added a Kconfig select statement on CONFIG_DEBUG_LIST, but the CONFIG_ >> prefix is only used in Make and C(PP) syntax. Remove the CONFIG_ prefix >> to correctly select the Kconfig option DEBUG_LIST. >> >> Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com> > > Well, color me blind! > > Good catch, queued for review and testing. > > Kees, Steve, Rik, any objections? Argh, thank you. Yes, this is correct. Acked-by: Kees Cook <keescook@chromium.org> -Kees > > Thanx, Paul > >> --- >> I detected the issue with scripts/checkkconfigsymbols.py >> >> lib/Kconfig.debug | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug >> index 5dea4d0a5a07..c2bbaae13d04 100644 >> --- a/lib/Kconfig.debug >> +++ b/lib/Kconfig.debug >> @@ -2009,7 +2009,7 @@ config TEST_STATIC_KEYS >> >> config BUG_ON_DATA_CORRUPTION >> bool "Trigger a BUG when data corruption is detected" >> - select CONFIG_DEBUG_LIST >> + select DEBUG_LIST >> help >> Select this option if the kernel should BUG when it encounters >> data corruption in kernel memory structures when they get checked >> -- >> 2.9.3 >> > -- Kees Cook Nexus Security ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-21 3:24 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-08-20 10:16 [PATCH] lib/Kconfig.debug: fix typo in select statement Valentin Rothberg 2016-08-20 18:20 ` Paul E. McKenney 2016-08-21 3:24 ` Kees Cook
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox