public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Colin King <colin.king@canonical.com>
Cc: Ian Abbott <abbotti@mev.co.uk>,
	H Hartley Sweeten <hsweeten@visionengravers.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: comedi: dt2811: add parentheses to fix logic on s->subdev_flags
Date: Sun, 21 Aug 2016 17:07:10 +0200	[thread overview]
Message-ID: <20160821150710.GA16155@kroah.com> (raw)
In-Reply-To: <1469485525-17632-1-git-send-email-colin.king@canonical.com>

On Mon, Jul 25, 2016 at 11:25:25PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> We need to add parentheses around ternary operations because currently
> the expression SDF_READABLE | (it->options[2] == 1) always evaluates to
> true, meaning s->subdev_flags is always assigned SDF_DIFF. Putting the
> parentheses around the ternarary operations results in the intended
> expression of SDF_REABLE logically or'd with one of SDF_DIFF,
> SDF_COMMON or SDF_GROUND.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Fixes: 7c9574090d30 ("staging: comedi: dt2811: simplify A/D reference configuration")
> Cc: <stable@vger.kernel.org> # 4.7+
> Reviewed-by: Ian Abbott <abbotti@mev.co.uk>


Dan sent a patch for this before you did :(

And this went into 4.8-rc1, not 4.7.

thanks,

greg k-h

      parent reply	other threads:[~2016-08-21 21:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-25 22:25 [PATCH] staging: comedi: dt2811: add parentheses to fix logic on s->subdev_flags Colin King
2016-07-26  9:19 ` Ian Abbott
2016-08-21 15:07 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160821150710.GA16155@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=abbotti@mev.co.uk \
    --cc=colin.king@canonical.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox