From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753847AbcHUVUH (ORCPT ); Sun, 21 Aug 2016 17:20:07 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34175 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753734AbcHUVUF (ORCPT ); Sun, 21 Aug 2016 17:20:05 -0400 Date: Sun, 21 Aug 2016 17:09:44 +0200 From: Greg KH To: Icenowy Zheng Cc: "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] staging: esp8089: add new driver Message-ID: <20160821150944.GA30371@kroah.com> References: <20160619123348.36735-1-icenowy@aosc.xyz> <20160620154324.GA28647@kroah.com> <523581466465724@web3g.yandex.ru> <20160621151714.GA25462@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160621151714.GA25462@kroah.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 21, 2016 at 08:17:14AM -0700, Greg KH wrote: > On Tue, Jun 21, 2016 at 07:35:24AM +0800, Icenowy Zheng wrote: > > The driver is only a working port of a badly written driver extracted from an old and vendor-specified kernel source. > > I cannot promise the code style (although I did indent -kr -i8). > > I cannot also promise the effect. > > I don't understand this at all, sorry. > > Why should we accept this driver? Who is going to maintain it? What > needs to be done to it? > > And why are you top-posting? :) Dropping from my queue due to lack of a response. If you fix it up, please resend it, but we need the answers to the above questions if you do so. thanks, greg k-h