From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754046AbcHUV0N (ORCPT ); Sun, 21 Aug 2016 17:26:13 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34280 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753230AbcHUVZh (ORCPT ); Sun, 21 Aug 2016 17:25:37 -0400 Date: Sun, 21 Aug 2016 17:34:49 +0200 From: Greg KH To: Claudiu Beznea Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: wlan-ng: removed unused code Message-ID: <20160821153449.GB31704@kroah.com> References: <1470678380-24409-1-git-send-email-claudiu.beznea@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1470678380-24409-1-git-send-email-claudiu.beznea@gmail.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 08, 2016 at 08:46:20PM +0300, Claudiu Beznea wrote: > This patch removes unused code from wlan-ng driver. > > Signed-off-by: Claudiu Beznea > --- > drivers/staging/wlan-ng/p80211types.h | 43 ----------------------------------- > 1 file changed, 43 deletions(-) > > diff --git a/drivers/staging/wlan-ng/p80211types.h b/drivers/staging/wlan-ng/p80211types.h > index 8cb4fc6..256c742 100644 > --- a/drivers/staging/wlan-ng/p80211types.h > +++ b/drivers/staging/wlan-ng/p80211types.h > @@ -205,20 +205,11 @@ typedef struct p80211enumpair { > char *name; > } p80211enumpair_t; > > -typedef struct p80211enum { > - int nitems; > - p80211enumpair_t *list; > -} p80211enum_t; > - > /*----------------------------------------------------------------*/ > /* The following structure types are used to store data items in */ > /* messages. */ > > /* Template pascal string */ > -typedef struct p80211pstr { > - u8 len; > -} __packed p80211pstr_t; > - > typedef struct p80211pstrd { > u8 len; > u8 data[0]; > @@ -301,14 +292,6 @@ typedef struct p80211item_pstr32 { > p80211pstr32_t data; > } __packed p80211item_pstr32_t; > > -/* message data item for OCTETSTR, DISPLAYSTR */ > -typedef struct p80211item_pstr255 { > - u32 did; > - u16 status; > - u16 len; > - p80211pstr255_t data; > -} __packed p80211item_pstr255_t; > - > /* message data item for UNK 392, namely mib items */ > typedef struct p80211item_unk392 { > u32 did; > @@ -346,30 +329,4 @@ typedef void (*p80211_fromtext_t) (struct catlistitem *, u32 did, u8 *itembuf, > char *textbuf); > typedef u32(*p80211_valid_t) (struct catlistitem *, u32 did, u8 *itembuf); > > -/*----------------------------------------------------------------*/ > -/* Enumeration Lists */ > -/* The following are the external declarations */ > -/* for all enumerations */ > - > -extern p80211enum_t MKENUMNAME(truth); > -extern p80211enum_t MKENUMNAME(ifstate); > -extern p80211enum_t MKENUMNAME(powermgmt); > -extern p80211enum_t MKENUMNAME(bsstype); > -extern p80211enum_t MKENUMNAME(authalg); > -extern p80211enum_t MKENUMNAME(phytype); > -extern p80211enum_t MKENUMNAME(temptype); > -extern p80211enum_t MKENUMNAME(regdomain); > -extern p80211enum_t MKENUMNAME(ccamode); > -extern p80211enum_t MKENUMNAME(diversity); > -extern p80211enum_t MKENUMNAME(scantype); > -extern p80211enum_t MKENUMNAME(resultcode); > -extern p80211enum_t MKENUMNAME(reason); > -extern p80211enum_t MKENUMNAME(status); > -extern p80211enum_t MKENUMNAME(msgcode); > -extern p80211enum_t MKENUMNAME(msgitem_status); > - > -extern p80211enum_t MKENUMNAME(lnxroam_reason); > - > -extern p80211enum_t MKENUMNAME(p2preamble); > - > #endif /* _P80211TYPES_H */ > -- > 1.9.1 I don't see any "code" removed, only unused typedefs and externs. Please be more specific in your changelog comments. thanks, greg k-h