From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754375AbcHUV3U (ORCPT <rfc822;w@1wt.eu>);
        Sun, 21 Aug 2016 17:29:20 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:34467 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754344AbcHUV3T (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 21 Aug 2016 17:29:19 -0400
Date: Sun, 21 Aug 2016 18:18:02 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Lidza Louina <lidza.louina@oracle.com>
Cc: Ivan Safonov <insafonov@gmail.com>,
        Kyle Kuffermann <kyle.kuffermann@gmail.com>,
        Sandhya Bankar <bankarsandhya512@gmail.com>,
        Geliang Tang <geliangtang@163.com>, Bryan Paul <bryan.paul@yahoo.com>,
        Bhaktipriya Shridhar <bhaktipriya96@gmail.com>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/rtl8188eu/core/rtw_cmd: Fixes semaphore locking
Message-ID: <20160821161802.GA20818@kroah.com>
References: <1470720897.23538.2.camel@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1470720897.23538.2.camel@oracle.com>
User-Agent: Mutt/1.7.0 (2016-08-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 09, 2016 at 01:34:57AM -0400, Lidza Louina wrote:
> The code did not lock the &pcmdpriv->terminate_cmdthread_sema before using it.
> The code had an up() where a down() should've been. This patch fixes that.
> 
> Signed-off-by: Lidza Louina <Lidza.Louina@oracle.com>
> ---
>  drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rtw_cmd.c
> index 7748523..16f0b19 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_cmd.c
> @@ -162,7 +162,7 @@ int rtw_cmd_thread(void *context)
>  	allow_signal(SIGTERM);
>  
>  	pcmdpriv->cmdthd_running = true;
> -	up(&pcmdpriv->terminate_cmdthread_sema);
> +	down(&pcmdpriv->terminate_cmdthread_sema);
>  
>  	RT_TRACE(_module_rtl871x_cmd_c_, _drv_info_, ("start r871x rtw_cmd_thread !!!!\n"));
>  
> -- 
> 2.7.4

This path is corrupted somehow and doesn't apply at all :(

Can you see what went wrong with your email client and try again?

thanks,

greg k-h