From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754396AbcHUV36 (ORCPT ); Sun, 21 Aug 2016 17:29:58 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34504 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753562AbcHUV3z (ORCPT ); Sun, 21 Aug 2016 17:29:55 -0400 Date: Sun, 21 Aug 2016 18:26:21 +0200 From: Greg Kroah-Hartman To: Binoy Jayan Cc: Larry Finger , Florian Schilhabel , driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH v2 4/4] rtl8712: pwrctrl_priv: Replace semaphore lock with mutex Message-ID: <20160821162621.GA13201@kroah.com> References: <1464841450-24772-1-git-send-email-binoy.jayan@linaro.org> <1464841450-24772-5-git-send-email-binoy.jayan@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464841450-24772-5-git-send-email-binoy.jayan@linaro.org> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 02, 2016 at 09:54:10AM +0530, Binoy Jayan wrote: > The semaphore 'lock' in 'pwrctrl_priv' is used as a simple mutex, so it > should be written as one. Semaphores are going away in the future. > _enter_pwrlock was using down_interruptible(), so the lock could be broken > by sending a signal. This could be a bug, because nothing checks the return > code here. Hence, using mutex_lock instead of the interruptible version. > Removing the now unused _enter_pwrlock and _down_sema. > > Signed-off-by: Binoy Jayan > Reviewed-by: Arnd Bergmann > Tested-by: Larry Finger > --- > This patch depends on the following patch: > rtl8712: intf_priv: Replace semaphore lock with completion This one patch doesn't apply to my tree for some odd reason. Can you rebase it on my staging-testing branch and resend it? thanks, greg k-h