From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753525AbcHVANk (ORCPT ); Sun, 21 Aug 2016 20:13:40 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:8883 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753164AbcHVANj (ORCPT ); Sun, 21 Aug 2016 20:13:39 -0400 X-IBM-Helo: d03dlp03.boulder.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com Date: Sun, 21 Aug 2016 16:00:33 -0700 From: "Paul E. McKenney" To: SeongJae Park Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] rcuperf: Remove unnecessary rcu_perf_writer_state variable Reply-To: paulmck@linux.vnet.ibm.com References: <1471766080-17501-1-git-send-email-sj38.park@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1471766080-17501-1-git-send-email-sj38.park@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16082123-0020-0000-0000-00000999EE55 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005625; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000183; SDB=6.00747816; UDB=6.00352840; IPR=6.00520455; BA=6.00004671; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00012409; XFM=3.00000011; UTC=2016-08-21 23:00:22 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16082123-0021-0000-0000-000054C44AAB Message-Id: <20160821230033.GS3482@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-21_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608210254 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 21, 2016 at 04:54:38PM +0900, SeongJae Park wrote: > rcu_perf_writer_state is being written only while nobody reads it. This > commit removes the unnecessary variable and macro constants for it. > > Signed-off-by: SeongJae Park > --- I am keeping rcu_perf_writer_state for debugging purposes, but I pulled in the other two patches for review and testing, thank you! Thanx, Paul > kernel/rcu/rcuperf.c | 16 ++-------------- > 1 file changed, 2 insertions(+), 14 deletions(-) > > diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c > index d38ab08..6025342 100644 > --- a/kernel/rcu/rcuperf.c > +++ b/kernel/rcu/rcuperf.c > @@ -86,13 +86,6 @@ static u64 t_rcu_perf_writer_finished; > static unsigned long b_rcu_perf_writer_started; > static unsigned long b_rcu_perf_writer_finished; > > -static int rcu_perf_writer_state; > -#define RTWS_INIT 0 > -#define RTWS_EXP_SYNC 1 > -#define RTWS_SYNC 2 > -#define RTWS_IDLE 2 > -#define RTWS_STOPPING 3 > - > #define MAX_MEAS 10000 > #define MIN_MEAS 100 > > @@ -381,14 +374,10 @@ rcu_perf_writer(void *arg) > do { > wdp = &wdpp[i]; > *wdp = ktime_get_mono_fast_ns(); > - if (gp_exp) { > - rcu_perf_writer_state = RTWS_EXP_SYNC; > + if (gp_exp) > cur_ops->exp_sync(); > - } else { > - rcu_perf_writer_state = RTWS_SYNC; > + else > cur_ops->sync(); > - } > - rcu_perf_writer_state = RTWS_IDLE; > t = ktime_get_mono_fast_ns(); > *wdp = t - *wdp; > i_max = i; > @@ -429,7 +418,6 @@ rcu_perf_writer(void *arg) > i++; > rcu_perf_wait_shutdown(); > } while (!torture_must_stop()); > - rcu_perf_writer_state = RTWS_STOPPING; > writer_n_durations[me] = i_max; > torture_kthread_stopping("rcu_perf_writer"); > return 0; > -- > 1.9.1 >