From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Icenowy Zheng <icenowy@aosc.xyz>
Cc: Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Hans de Goede <hdegoede@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Michal Suchanek <hramrach@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH v3 1/2] Documentation: dt: Add new compatible to sunxi mmc driver bindings
Date: Mon, 22 Aug 2016 09:58:47 +0200 [thread overview]
Message-ID: <20160822075847.GD7104@lukather> (raw)
In-Reply-To: <20160801151351.51854-2-icenowy@aosc.xyz>
[-- Attachment #1: Type: text/plain, Size: 1154 bytes --]
Hi Icenowy,
On Mon, Aug 01, 2016 at 11:13:50PM +0800, Icenowy Zheng wrote:
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> ---
> Changes in v2:
> - Rebased on Hans de Goede's patchset.
>
> Documentation/devicetree/bindings/mmc/sunxi-mmc.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/sunxi-mmc.txt b/Documentation/devicetree/bindings/mmc/sunxi-mmc.txt
> index 904ff9f..55cdd80 100644
> --- a/Documentation/devicetree/bindings/mmc/sunxi-mmc.txt
> +++ b/Documentation/devicetree/bindings/mmc/sunxi-mmc.txt
> @@ -13,6 +13,7 @@ Required properties:
> * "allwinner,sun5i-a13-mmc"
> * "allwinner,sun7i-a20-mmc"
> * "allwinner,sun9i-a80-mmc"
> + * "allwinner,sun50i-a64-mmc"
> - reg : mmc controller base registers
> - clocks : a list with 4 phandle + clock specifier pairs
> - clock-names : must contain "ahb", "mmc", "output" and "sample"
You need to document that the output and sample clocks are not
mandatory in the A64 case.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-08-22 7:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160801151351.51854-1-icenowy@aosc.xyz>
2016-08-02 8:45 ` [PATCH v3 0/2] Add support for Allwinner A64 mmc controller Hans de Goede
[not found] ` <CGME20160801151434epcas1p15f57862a238cf493445ed667f37a8a88@epcas1p1.samsung.com>
[not found] ` <20160801151351.51854-3-icenowy@aosc.xyz>
2016-08-02 23:43 ` [PATCH v3 2/2] mmc: host: sunxi: add support for " Jaehoon Chung
[not found] ` <20160801151351.51854-2-icenowy@aosc.xyz>
2016-08-22 7:58 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160822075847.GD7104@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=hramrach@gmail.com \
--cc=icenowy@aosc.xyz \
--cc=jh80.chung@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox