From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753854AbcHVIPv (ORCPT ); Mon, 22 Aug 2016 04:15:51 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40506 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750988AbcHVIPs (ORCPT ); Mon, 22 Aug 2016 04:15:48 -0400 Date: Mon, 22 Aug 2016 04:15:55 -0400 From: "'Greg KH'" To: "Sell, Timothy C" Cc: "corbet@lwn.net" , "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "Arfvidson, Erik" , "hofrat@osadl.org" , "dzickus@redhat.com" , "jes.sorensen@redhat.com" , "Curtin, Alexander Paul" , "janani.rvchndrn@gmail.com" , "sudipm.mukherjee@gmail.com" , "prarit@redhat.com" , "Binder, David Anthony" , "nhorman@redhat.com" , "dan.j.williams@intel.com" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , "driverdev-devel@linuxdriverproject.org" , *S-Par-Maintainer , "Kershner, David A" Subject: Re: [PATCH 3/3] drivers: Add visorbus to the drivers/virt directory Message-ID: <20160822081555.GA5113@kroah.com> References: <1465615436-16035-1-git-send-email-david.kershner@unisys.com> <1465615436-16035-4-git-send-email-david.kershner@unisys.com> <20160821180458.GA10469@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 22, 2016 at 02:48:18AM +0000, Sell, Timothy C wrote: > > -----Original Message----- > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > Sent: Sunday, August 21, 2016 2:05 PM > > To: Kershner, David A > > Cc: corbet@lwn.net; tglx@linutronix.de; mingo@redhat.com; > > hpa@zytor.com; Arfvidson, Erik ; Sell, Timothy > > C ; hofrat@osadl.org; dzickus@redhat.com; > > jes.sorensen@redhat.com; Curtin, Alexander Paul > > ; janani.rvchndrn@gmail.com; > > sudipm.mukherjee@gmail.com; prarit@redhat.com; Binder, David Anthony > > ; nhorman@redhat.com; > > dan.j.williams@intel.com; linux-kernel@vger.kernel.org; linux- > > doc@vger.kernel.org; driverdev-devel@linuxdriverproject.org; *S-Par- > > Maintainer > > Subject: Re: [PATCH 3/3] drivers: Add visorbus to the drivers/virt directory > > > > On Fri, Jun 10, 2016 at 11:23:56PM -0400, David Kershner wrote: > > > visorbus is currently located at drivers/staging/visorbus, > > > this patch moves it to drivers/virt. > > > > > > Signed-off-by: David Kershner > > > Reviewed-by: Tim Sell > > > --- > > > drivers/staging/unisys/Kconfig | 3 +-- > > > drivers/staging/unisys/Makefile | 1 - > > > drivers/virt/Kconfig | 2 ++ > > > drivers/virt/Makefile | 1 + > > > drivers/{staging/unisys => virt}/visorbus/Kconfig | 0 > > > drivers/{staging/unisys => virt}/visorbus/Makefile | 0 > > > drivers/{staging/unisys => virt}/visorbus/controlvmchannel.h | 0 > > > drivers/{staging/unisys => virt}/visorbus/controlvmcompletionstatus.h | 0 > > > drivers/{staging/unisys => virt}/visorbus/iovmcall_gnuc.h | 0 > > > drivers/{staging/unisys => virt}/visorbus/vbuschannel.h | 0 > > > drivers/{staging/unisys => virt}/visorbus/vbusdeviceinfo.h | 0 > > > drivers/{staging/unisys => virt}/visorbus/vbushelper.h | 0 > > > drivers/{staging/unisys => virt}/visorbus/visorbus_main.c | 0 > > > drivers/{staging/unisys => virt}/visorbus/visorbus_private.h | 0 > > > drivers/{staging/unisys => virt}/visorbus/visorchannel.c | 0 > > > drivers/{staging/unisys => virt}/visorbus/visorchipset.c | 0 > > > > I picked one random file here, this last one, and found a number of > > "odd" things in it. > > > > So, given that I can't really comment on the patch itself, I'm going to > > include the file below, quote it, and then provide some comments, ok? > > > /* visorchipset_main.c > > > ... > > > static void > > > controlvm_init_response(struct controlvm_message *msg, > > > struct controlvm_message_header *msg_hdr, int response) > > > { > > > memset(msg, 0, sizeof(struct controlvm_message)); > > > memcpy(&msg->hdr, msg_hdr, sizeof(struct controlvm_message_header)); > > > msg->hdr.payload_bytes = 0; > > > msg->hdr.payload_vm_offset = 0; > > > msg->hdr.payload_max_bytes = 0; > > > if (response < 0) { > > > msg->hdr.flags.failed = 1; > > > msg->hdr.completion_status = (u32)(-response); > > > } > > > } > > > > > > static void > > > Billy(struct controlvm_message_header *msg_hdr, int response) > > > > Not John? Bob? Sally? Alice? Bernise? Jean? Molly? > > Huh? What version of source code are you looking at?? > > The file being moved by this patch should be > drivers/staging/unisys/visorbus/visorchipset.c in your staging-next branch > (https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/tree/drivers/staging/unisys/visorbus/visorchipset.c?h=staging-next). > If you look there, you will NOT find "Billy()", but instead "controlvm_respond()", i.e.: > > static void > controlvm_init_response(struct controlvm_message *msg, > struct controlvm_message_header *msg_hdr, int response) oh that's funny, I have no idea what happened here, perhaps when I copied the file into the original email? Strange things happen while on planes... Anyway, ok, one comment addressed, great! Now about the many many others? thanks, greg k-h