From: Jiri Olsa <jolsa@redhat.com>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Stephane Eranian <eranian@google.com>,
Vince Weaver <vincent.weaver@maine.edu>,
Ingo Molnar <mingo@kernel.org>,
David Carrillo-Cisneros <davidcc@google.com>,
Peter Zijlstra <peterz@infradead.org>,
"H. Peter Anvin" <hpa@zytor.com>, Kan Liang <kan.liang@intel.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Paul Turner <pjt@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/core] perf/core: Check return value of the perf_event_read() IPI
Date: Mon, 22 Aug 2016 10:29:32 +0200 [thread overview]
Message-ID: <20160822082932.GA13171@krava> (raw)
In-Reply-To: <20160822071737.GF4349@krava>
On Mon, Aug 22, 2016 at 09:17:37AM +0200, Jiri Olsa wrote:
> On Sun, Aug 21, 2016 at 02:10:07PM +0200, Vegard Nossum wrote:
>
> SNIP
>
> > [<ffffffff816d1577>] ? __fget+0x47/0x270
> > [<ffffffff81676d5b>] vfs_readv+0x8b/0xc0
> > [<ffffffff81676e6e>] do_readv+0xde/0x230
> > [<ffffffff81676d90>] ? vfs_readv+0xc0/0xc0
> > [<ffffffff81002b60>] ? exit_to_usermode_loop+0x190/0x190
> > [<ffffffff82001b07>] ? check_preemption_disabled+0x37/0x1e0
> > [<ffffffff81677617>] SyS_readv+0x27/0x30
> > [<ffffffff816775f0>] ? do_pwritev+0x1a0/0x1a0
> > [<ffffffff81005524>] do_syscall_64+0x1c4/0x4e0
> > [<ffffffff83c3286a>] entry_SYSCALL64_slow_path+0x25/0x25
> >
> > I don't think WARN() is the right interface for signalling errors to
> > userspace programs?
>
> any special way to trigger that?
nope ;-)
perf stat -a -I 10
jirka
--
[ 430.168408] ------------[ cut here ]------------
[ 430.173596] WARNING: CPU: 10 PID: 3878 at kernel/events/core.c:3583 perf_event_read+0x1cc/0x1e0
[ 430.183321] Modules linked in: intel_rapl sb_edac edac_core x86_pkg_temp_thermal coretemp iTCO_wdt crct10dif_pclmul iTCO_vendor_support crc32_pclmul ghash_clmulni_intel cdc_ether usbnet mii ioatdma i2c_i801 lpc_ich i2c_smbus wmi xfs libcrc32c mgag200 drm_kms_helper igb ttm ptp pps_core crc32c_intel dca drm i2c_algo_bit megaraid_sas fjes
[ 430.217193] CPU: 10 PID: 3878 Comm: perf Not tainted 4.8.0-rc2+ #227
[ 430.224282] Hardware name: IBM System x3650 M4 : -[7915E2G]-/00Y7683, BIOS -[VVE124AUS-1.30]- 11/21/2012
[ 430.234863] 0000000000000286 00000000e92a6a39 ffff880275c7bcd8 ffffffff813ba21e
[ 430.243156] 0000000000000000 0000000000000000 ffff880275c7bd18 ffffffff810a16ab
[ 430.251446] 00000dff75c7bd78 ffff88047444c000 ffff880275c7bde0 0000000000000003
[ 430.259736] Call Trace:
[ 430.262466] [<ffffffff813ba21e>] dump_stack+0x63/0x85
[ 430.268193] [<ffffffff810a16ab>] __warn+0xcb/0xf0
[ 430.273539] [<ffffffff810a17dd>] warn_slowpath_null+0x1d/0x20
[ 430.280048] [<ffffffff8118ec7c>] perf_event_read+0x1cc/0x1e0
[ 430.286461] [<ffffffff8118ecd5>] perf_event_read_value+0x45/0x130
[ 430.293358] [<ffffffff81192a03>] perf_read+0x93/0x2c0
[ 430.299093] [<ffffffff81344879>] ? file_has_perm+0xa9/0xb0
[ 430.305314] [<ffffffff81231327>] __vfs_read+0x37/0x150
[ 430.311137] [<ffffffff8133af60>] ? security_file_permission+0xa0/0xc0
[ 430.318431] [<ffffffff81232505>] vfs_read+0x95/0x140
[ 430.324069] [<ffffffff81233a05>] SyS_read+0x55/0xc0
[ 430.329610] [<ffffffff8178b972>] entry_SYSCALL_64_fastpath+0x1a/0xa4
[ 430.336820] ---[ end trace 671c766962c86ad2 ]---
next prev parent reply other threads:[~2016-08-22 8:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 20:55 [PATCH v3 0/4] remove unnecessary IPI reading uncore events David Carrillo-Cisneros
2016-08-17 20:55 ` [PATCH v3 1/4] perf/core: check return value of perf_event_read IPI David Carrillo-Cisneros
2016-08-18 10:52 ` [tip:perf/core] perf/core: Check return value of the perf_event_read() IPI tip-bot for David Carrillo-Cisneros
2016-08-21 12:10 ` Vegard Nossum
2016-08-22 7:17 ` Jiri Olsa
2016-08-22 8:29 ` Jiri Olsa [this message]
2016-08-22 10:38 ` Jiri Olsa
2016-08-28 18:09 ` Jiri Olsa
2016-08-29 10:03 ` Peter Zijlstra
2016-08-29 13:02 ` Peter Zijlstra
2016-08-29 13:14 ` Vince Weaver
2016-08-29 18:58 ` Jiri Olsa
2016-08-30 6:47 ` Peter Zijlstra
2016-08-30 7:26 ` Peter Zijlstra
2016-08-30 9:47 ` Jiri Olsa
2016-08-30 16:26 ` Stephane Eranian
2016-09-02 8:33 ` Peter Zijlstra
2016-10-09 7:09 ` [lkp] [perf/core] 412929295f: WARNING: CPU: 2 PID: 600 at kernel/events/core.c:3530 perf_event_read+0x17d/0x190 kernel test robot
2016-08-17 20:55 ` [PATCH v3 2/4] perf/core: generalize event->group_flags David Carrillo-Cisneros
2016-08-18 10:53 ` [tip:perf/core] perf/core: Generalize event->group_flags tip-bot for David Carrillo-Cisneros
2016-08-17 20:55 ` [PATCH v3 3/4] perf/core: introduce PMU_EV_CAP_READ_ACTIVE_PKG David Carrillo-Cisneros
2016-08-18 10:54 ` [tip:perf/core] perf/core: Introduce PMU_EV_CAP_READ_ACTIVE_PKG tip-bot for David Carrillo-Cisneros
2016-08-17 20:55 ` [PATCH v3 4/4] perf/x86: use PMUEF_READ_CPU_PKG in uncore events David Carrillo-Cisneros
2016-08-18 10:54 ` [tip:perf/core] perf/x86: Use " tip-bot for David Carrillo-Cisneros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160822082932.GA13171@krava \
--to=jolsa@redhat.com \
--cc=acme@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=davidcc@google.com \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vegard.nossum@gmail.com \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).