public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	Mathias Nyman <mathias.nyman@linux.intel.com>,
	<linux-gpio@vger.kernel.org>
Subject: [PATCH 1/4] gpio: msic: drop unused MODULE_ tags from non-modular code
Date: Mon, 22 Aug 2016 12:48:30 -0400	[thread overview]
Message-ID: <20160822164833.3633-2-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <20160822164833.3633-1-paul.gortmaker@windriver.com>

The Kconfig currently controlling compilation of this code is:

drivers/gpio/Kconfig:config GPIO_MSIC
drivers/gpio/Kconfig:   bool "Intel MSIC mixed signal gpio support"

...meaning that it currently is not being built as a module by anyone.

Lets remove the couple traces of modular infrastructure use, so that
when reading the driver there is no doubt it is builtin-only.

We delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.

We don't replace module.h with init.h since the file already has that.

Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/gpio/gpio-msic.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/gpio/gpio-msic.c b/drivers/gpio/gpio-msic.c
index d75649787e6c..1b7ce7f85886 100644
--- a/drivers/gpio/gpio-msic.c
+++ b/drivers/gpio/gpio-msic.c
@@ -20,7 +20,6 @@
  *
  */
 
-#include <linux/module.h>
 #include <linux/kernel.h>
 #include <linux/slab.h>
 #include <linux/interrupt.h>
@@ -328,9 +327,4 @@ static int __init platform_msic_gpio_init(void)
 {
 	return platform_driver_register(&platform_msic_gpio_driver);
 }
-
 subsys_initcall(platform_msic_gpio_init);
-
-MODULE_AUTHOR("Mathias Nyman <mathias.nyman@linux.intel.com>");
-MODULE_DESCRIPTION("Intel Medfield MSIC GPIO driver");
-MODULE_LICENSE("GPL v2");
-- 
2.8.4

  reply	other threads:[~2016-08-22 16:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-22 16:48 [PATCH 0/4] gpio: delete MODULE_ tags in non-modular drivers Paul Gortmaker
2016-08-22 16:48 ` Paul Gortmaker [this message]
2016-08-23  9:22   ` [PATCH 1/4] gpio: msic: drop unused MODULE_ tags from non-modular code Linus Walleij
2016-08-22 16:48 ` [PATCH 2/4] gpio: mxc: " Paul Gortmaker
2016-08-23  9:23   ` Linus Walleij
2016-08-22 16:48 ` [PATCH 3/4] gpio: spear-spics: " Paul Gortmaker
2016-08-23  9:24   ` Linus Walleij
2016-08-23 15:19   ` Masahiro Yamada
2016-08-22 16:48 ` [PATCH 4/4] gpio: vf610: " Paul Gortmaker
2016-08-23  9:25   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160822164833.3633-2-paul.gortmaker@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=gnurou@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathias.nyman@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox